Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: chrome/browser/budget_service/budget_service_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/budget_service/budget_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/budget_service/budget_service_impl.h
diff --git a/chrome/browser/budget_service/budget_service_impl.h b/chrome/browser/budget_service/budget_service_impl.h
index 9363d996fa1edf77d86bc3b14b15d48175f7fe36..9fe3d15cf6906a35c838985d88621b1b5e5618b8 100644
--- a/chrome/browser/budget_service/budget_service_impl.h
+++ b/chrome/browser/budget_service/budget_service_impl.h
@@ -6,7 +6,6 @@
#define CHROME_BROWSER_BUDGET_SERVICE_BUDGET_SERVICE_IMPL_H_
#include "base/macros.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
#include "third_party/WebKit/public/platform/modules/budget_service/budget_service.mojom.h"
// Implementation of the BudgetService Mojo service provided by the browser
@@ -14,6 +13,9 @@
// BudgetManager.
class BudgetServiceImpl : public blink::mojom::BudgetService {
public:
+ explicit BudgetServiceImpl(int render_process_id);
+ ~BudgetServiceImpl() override;
+
static void Create(int render_process_id,
blink::mojom::BudgetServiceRequest request);
@@ -27,16 +29,9 @@ class BudgetServiceImpl : public blink::mojom::BudgetService {
const ReserveCallback& callback) override;
private:
- BudgetServiceImpl(int render_process_id,
- blink::mojom::BudgetServiceRequest request);
- ~BudgetServiceImpl() override;
-
// Render process ID is used to get the browser context.
int render_process_id_;
- // The lifetime of the mojo service is tied to the lifetime of the connection.
- mojo::StrongBinding<blink::mojom::BudgetService> binding_;
-
DISALLOW_COPY_AND_ASSIGN(BudgetServiceImpl);
};
« no previous file with comments | « no previous file | chrome/browser/budget_service/budget_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698