Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: chrome/browser/budget_service/budget_service_impl.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/budget_service/budget_service_impl.cc
diff --git a/chrome/browser/budget_service/budget_service_impl.cc b/chrome/browser/budget_service/budget_service_impl.cc
index e483e79e700fbc4630975ba02239dda9bb09c60d..be1f910d242380c3f5c996e972fa2aad0d4e3bc8 100644
--- a/chrome/browser/budget_service/budget_service_impl.cc
+++ b/chrome/browser/budget_service/budget_service_impl.cc
@@ -8,20 +8,21 @@
#include "chrome/browser/budget_service/budget_manager_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "content/public/browser/render_process_host.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
+
+BudgetServiceImpl::BudgetServiceImpl(int render_process_id)
+ : render_process_id_(render_process_id) {}
+
+BudgetServiceImpl::~BudgetServiceImpl() = default;
// static
void BudgetServiceImpl::Create(int render_process_id,
blink::mojom::BudgetServiceRequest request) {
- new BudgetServiceImpl(render_process_id, std::move(request));
+ mojo::MakeStrongBinding(
+ base::MakeUnique<BudgetServiceImpl>(render_process_id),
+ std::move(request));
}
-BudgetServiceImpl::BudgetServiceImpl(int render_process_id,
- blink::mojom::BudgetServiceRequest request)
- : render_process_id_(render_process_id),
- binding_(this, std::move(request)) {}
-
-BudgetServiceImpl::~BudgetServiceImpl() = default;
-
void BudgetServiceImpl::GetCost(blink::mojom::BudgetOperationType type,
const GetCostCallback& callback) {
// The RenderProcessHost should still be alive as long as any connections are
« no previous file with comments | « chrome/browser/budget_service/budget_service_impl.h ('k') | chrome/browser/chromeos/arc/gpu_arc_video_service_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698