Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2326823002: [ios] Removed CHECK that URL passed to setDocumentURL: is invalid. (Closed)

Created:
4 years, 3 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed CHECK that URL passed to setDocumentURL: is invalid. TBR=kkhorimoto@chromium.org BUG=635399 Committed: https://crrev.com/670987d1a53ccae46b9092aba97840e8e87a0d7f Cr-Commit-Position: refs/heads/master@{#417429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
pkl (ping after 24h if needed)
lgtm
4 years, 3 months ago (2016-09-08 22:10:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326823002/1
4 years, 3 months ago (2016-09-08 22:10:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 23:05:59 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 23:08:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/670987d1a53ccae46b9092aba97840e8e87a0d7f
Cr-Commit-Position: refs/heads/master@{#417429}

Powered by Google App Engine
This is Rietveld 408576698