ios/web/web_state/ui/crw_web_controller.mm - Issue 2326823002: [ios] Removed CHECK that URL passed to setDocumentURL: is invalid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2326823002: [ios] Removed CHECK that URL passed to setDocumentURL: is invalid. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_web_controller.mm

diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm

index e7fe4f3c9eb05ce6788928bf465f04c870a81dd1..dc3481e98672a674ff3fc7660a59a372f86d93be 100644

--- a/ios/web/web_state/ui/crw_web_controller.mm

+++ b/ios/web/web_state/ui/crw_web_controller.mm

@@ -1487,7 +1487,6 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;

- (void)setDocumentURL:(const GURL&)newURL {

if (newURL != _documentURL) {

- CHECK(newURL.is_valid());

_documentURL = newURL;

_interactionRegisteredSinceLastURLChange = NO;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »