Issue 2326783004: [Payments] PaymentRequestUI should be dismissed on tab changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2326783004: [Payments] PaymentRequestUI should be dismissed on tab changes (Closed)

Created:
4 years, 3 months ago by gone

Modified:
4 years, 3 months ago

Reviewers:
please use gerrit instead

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

[Payments] PaymentRequestUI should be dismissed on tab changes * Add observers to ensure that the dialog goes away when it shouldn't be kept on top of Clank. * Add tests to make sure that navigating somewhere, closing the tab, or opening a new tab dismisses the dialog. BUG=644855, 629071 TBR=rouslan@chromium.org Original Review-Url: https://codereview.chromium.org/2320063003 Committed: https://chromium.googlesource.com/chromium/src/+/4885e92a2d0d43b746c5b39a12aa8d05e49fae6c

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+131 lines, -2 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java	View	6 chunks	+36 lines, -2 lines	0 comments	Download
M	chrome/android/java_sources.gni	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTabTest.java	View	1 chunk	+94 lines, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

gone

Committed patchset #1 (id:1) manually as 4885e92a2d0d43b746c5b39a12aa8d05e49fae6c (presubmit successful).

4 years, 3 months ago (2016-09-09 00:45:18 UTC) #2

Message was sent while issue was closed.

lgtm