[Payments] PaymentRequestUI should be dismissed on tab changes

[Payments] PaymentRequestUI should be dismissed on tab changes

* Add observers to ensure that the dialog goes away when it shouldn't
  be kept on top of Clank.

* Add tests to make sure that navigating somewhere, closing the tab,
  or opening a new tab dismisses the dialog.

BUG=644855, 629071
Committed: https://crrev.com/40db87010a9c66e974200ddfe5b5ca4f70cb130d
Cr-Commit-Position: refs/heads/master@{#417414}

[gone, 2016-09-08 18:24:55]

dfalcantara@chromium.org changed reviewers:
+ rouslan@chromium.org

[gone, 2016-09-08 18:25:47]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 18:26:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-09-08 18:54:05]

Description was changed from

==========
[Payments] PaymentRequestUI should be dismissed on tab changes

* Add observers to ensure that the dialog goes away when it shouldn't
  be kept on top of Clank.

* Add tests to make sure that navigating somewhere, closing the tab,
  or opening a new tab dismisses the dialog.

BUG=644855
==========

to

==========
[Payments] PaymentRequestUI should be dismissed on tab changes

* Add observers to ensure that the dialog goes away when it shouldn't
  be kept on top of Clank.

* Add tests to make sure that navigating somewhere, closing the tab,
  or opening a new tab dismisses the dialog.

BUG=644855,629071
==========

[commit-bot: I haz the power, 2016-09-08 19:48:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 19:48:20]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2016-09-08 20:20:51]

+1000

(lgtm%nit)

https://codereview.chromium.org/2320063003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2320063003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:377:
// See https://crbug.com/644855.
Nit: Remove the link to the bug, because you already have BUG=644855 on the CL
description and this CL fixes 644855.

[gone, 2016-09-08 20:33:45]

https://chromiumcodereview.appspot.com/2320063003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://chromiumcodereview.appspot.com/2320063003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:377:
// See https://crbug.com/644855.
On 2016/09/08 20:20:51, rouslan wrote:
> Nit: Remove the link to the bug, because you already have BUG=644855 on the CL
> description and this CL fixes 644855.

Done.

[gone, 2016-09-08 20:33:51]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-09-08 20:33:51]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2320063003/#ps20001
(title: "Nits")

[commit-bot: I haz the power, 2016-09-08 20:34:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 22:08:10]

Description was changed from

==========
[Payments] PaymentRequestUI should be dismissed on tab changes

* Add observers to ensure that the dialog goes away when it shouldn't
  be kept on top of Clank.

* Add tests to make sure that navigating somewhere, closing the tab,
  or opening a new tab dismisses the dialog.

BUG=644855,629071
==========

to

==========
[Payments] PaymentRequestUI should be dismissed on tab changes

* Add observers to ensure that the dialog goes away when it shouldn't
  be kept on top of Clank.

* Add tests to make sure that navigating somewhere, closing the tab,
  or opening a new tab dismisses the dialog.

BUG=644855,629071
==========

[commit-bot: I haz the power, 2016-09-08 22:08:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 22:10:16]

Description was changed from

==========
[Payments] PaymentRequestUI should be dismissed on tab changes

* Add observers to ensure that the dialog goes away when it shouldn't
  be kept on top of Clank.

* Add tests to make sure that navigating somewhere, closing the tab,
  or opening a new tab dismisses the dialog.

BUG=644855,629071
==========

to

==========
[Payments] PaymentRequestUI should be dismissed on tab changes

* Add observers to ensure that the dialog goes away when it shouldn't
  be kept on top of Clank.

* Add tests to make sure that navigating somewhere, closing the tab,
  or opening a new tab dismisses the dialog.

BUG=644855,629071

Committed: https://crrev.com/40db87010a9c66e974200ddfe5b5ca4f70cb130d
Cr-Commit-Position: refs/heads/master@{#417414}
==========

[commit-bot: I haz the power, 2016-09-08 22:10:17]

Patchset 2 (id:??) landed as
https://crrev.com/40db87010a9c66e974200ddfe5b5ca4f70cb130d
Cr-Commit-Position: refs/heads/master@{#417414}