Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 2326693002: Fix documentation on connect time in LoadTimingInfo (Closed)

Created:
4 years, 3 months ago by mgersh
Modified:
4 years, 3 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix documentation on connect time in LoadTimingInfo The comment on connect_start and connect_end incorrectly stated that DNS lookup time is included in connect time. The comment above about order of events has the correct order. Committed: https://crrev.com/3e588a3a87498f27636ff610a0cbf961f99d41b1 Cr-Commit-Position: refs/heads/master@{#417385}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rearrange comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/base/load_timing_info.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mgersh
PTAL
4 years, 3 months ago (2016-09-08 18:55:15 UTC) #2
xunjieli
On 2016/09/08 18:55:15, mgersh wrote: > PTAL Could you get rid of "BUG=" or link ...
4 years, 3 months ago (2016-09-08 18:57:16 UTC) #3
mmenke
LGTM https://codereview.chromium.org/2326693002/diff/1/net/base/load_timing_info.h File net/base/load_timing_info.h (right): https://codereview.chromium.org/2326693002/diff/1/net/base/load_timing_info.h#newcode81 net/base/load_timing_info.h:81: // certain queues, TCP, and SSL time. It ...
4 years, 3 months ago (2016-09-08 18:57:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326693002/20001
4 years, 3 months ago (2016-09-08 19:05:19 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 20:35:45 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 20:38:09 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e588a3a87498f27636ff610a0cbf961f99d41b1
Cr-Commit-Position: refs/heads/master@{#417385}

Powered by Google App Engine
This is Rietveld 408576698