Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: net/base/load_timing_info.h

Issue 2326693002: Fix documentation on connect time in LoadTimingInfo (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_BASE_LOAD_TIMING_INFO_H_ 5 #ifndef NET_BASE_LOAD_TIMING_INFO_H_
6 #define NET_BASE_LOAD_TIMING_INFO_H_ 6 #define NET_BASE_LOAD_TIMING_INFO_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 // The time spent looking up the host's DNS address. Null for requests that 70 // The time spent looking up the host's DNS address. Null for requests that
71 // used proxies to look up the DNS address. Also null for SOCKS4 proxies, 71 // used proxies to look up the DNS address. Also null for SOCKS4 proxies,
72 // since the DNS address is only looked up after the connection is 72 // since the DNS address is only looked up after the connection is
73 // established, which results in unexpected event ordering. 73 // established, which results in unexpected event ordering.
74 // TODO(mmenke): The SOCKS4 event ordering could be refactored to allow 74 // TODO(mmenke): The SOCKS4 event ordering could be refactored to allow
75 // these times to be non-null. 75 // these times to be non-null.
76 base::TimeTicks dns_start; 76 base::TimeTicks dns_start;
77 base::TimeTicks dns_end; 77 base::TimeTicks dns_end;
78 78
79 // The time spent establishing the connection. Connect time includes proxy 79 // The time spent establishing the connection. Connect time includes proxy
80 // connect times (Though not proxy_resolve times), DNS lookup times, time 80 // connect times (though not proxy_resolve times), time spent waiting in
81 // spent waiting in certain queues, TCP, and SSL time. 81 // certain queues, TCP, and SSL time. It does not include DNS lookup time.
mmenke 2016/09/08 18:57:34 Maybe move this up with the "proxy_resolve" times
82 // TODO(mmenke): For proxies, this includes time spent blocking on higher 82 // TODO(mmenke): For proxies, this includes time spent blocking on higher
83 // level socket pools. Fix this. 83 // level socket pools. Fix this.
84 // TODO(mmenke): Retried connections to the same server should apparently 84 // TODO(mmenke): Retried connections to the same server should apparently
85 // be included in this time. Consider supporting that. 85 // be included in this time. Consider supporting that.
86 // Since the network stack has multiple notions of a "retry", 86 // Since the network stack has multiple notions of a "retry",
87 // handled at different levels, this may not be worth 87 // handled at different levels, this may not be worth
88 // worrying about - backup jobs, reused socket failure, 88 // worrying about - backup jobs, reused socket failure,
89 // multiple round authentication. 89 // multiple round authentication.
90 base::TimeTicks connect_start; 90 base::TimeTicks connect_start;
91 base::TimeTicks connect_end; 91 base::TimeTicks connect_end;
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 // the times that push started and ended. Note that push_end will be null 146 // the times that push started and ended. Note that push_end will be null
147 // if the request is still being transmitted, i.e. the underlying h2 stream 147 // if the request is still being transmitted, i.e. the underlying h2 stream
148 // is not closed by the server. 148 // is not closed by the server.
149 base::TimeTicks push_start; 149 base::TimeTicks push_start;
150 base::TimeTicks push_end; 150 base::TimeTicks push_end;
151 }; 151 };
152 152
153 } // namespace net 153 } // namespace net
154 154
155 #endif // NET_BASE_LOAD_TIMING_INFO_H_ 155 #endif // NET_BASE_LOAD_TIMING_INFO_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698