Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2326653002: Add a missing cast to ValueDeserializer::ReadVarint. (Closed)

Created:
4 years, 3 months ago by jbroman
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a missing cast to ValueDeserializer::ReadVarint. Without this cast, the integer type isn't promoted before being shifted, and so for types larger than sizeof(int) there is data loss. This will become an issue once the host begins using this helper to send 64-bit integers. BUG=chromium:148757 Committed: https://crrev.com/4c0ca533e726de080ad12366e6c56fe8f90b656e Cr-Commit-Position: refs/heads/master@{#39296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/value-serializer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
jbroman
Fixed this bug in Blink (https://codereview.chromium.org/2321713002), only to realize I had made the same mistake ...
4 years, 3 months ago (2016-09-08 18:03:22 UTC) #4
Camillo Bruni
lgtm
4 years, 3 months ago (2016-09-08 18:42:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326653002/1
4 years, 3 months ago (2016-09-08 19:03:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 19:05:45 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 19:06:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c0ca533e726de080ad12366e6c56fe8f90b656e
Cr-Commit-Position: refs/heads/master@{#39296}

Powered by Google App Engine
This is Rietveld 408576698