Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2326593003: Audit the use of UpdateStyleAndLayoutIgnorePendingStylesheets in FrameSelection::revealSelection (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Audit the use of UpdateStyleAndLayoutIgnorePendingStylesheets in FrameSelection::revealSelection BUG=590369 Committed: https://crrev.com/8eb88763df5a272f9cd161689c7273da125167a1 Cr-Commit-Position: refs/heads/master@{#417873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 3 chunks +19 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-09 09:57:18 UTC) #4
yosin_UTC9
lgtm
4 years, 3 months ago (2016-09-12 02:28:17 UTC) #7
tkent
lgtm
4 years, 3 months ago (2016-09-12 03:46:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326593003/1
4 years, 3 months ago (2016-09-12 04:21:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 05:56:45 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 05:58:46 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8eb88763df5a272f9cd161689c7273da125167a1
Cr-Commit-Position: refs/heads/master@{#417873}

Powered by Google App Engine
This is Rietveld 408576698