Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 2326593003: Audit the use of UpdateStyleAndLayoutIgnorePendingStylesheets in FrameSelection::revealSelection (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 323 matching lines...) Expand 10 before | Expand all | Expand 10 after
334 restoreCachedSelection(); 334 restoreCachedSelection();
335 break; 335 break;
336 case SelectionBehaviorOnFocus::None: 336 case SelectionBehaviorOnFocus::None:
337 return; 337 return;
338 } 338 }
339 // TODO(tkent): scrollRectToVisible is a workaround of a bug of 339 // TODO(tkent): scrollRectToVisible is a workaround of a bug of
340 // FrameSelection::revealSelection(). It doesn't scroll correctly in a 340 // FrameSelection::revealSelection(). It doesn't scroll correctly in a
341 // case of RangeSelection. crbug.com/443061. 341 // case of RangeSelection. crbug.com/443061.
342 if (layoutObject()) 342 if (layoutObject())
343 layoutObject()->scrollRectToVisible(boundingBox()); 343 layoutObject()->scrollRectToVisible(boundingBox());
344 if (document().frame()) 344 if (document().frame()) {
345 // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingSty lesheets
346 // needs to be audited. See http://crbug.com/590369 for more detail s.
347 document().updateStyleAndLayoutIgnorePendingStylesheets();
348
345 document().frame()->selection().revealSelection(); 349 document().frame()->selection().revealSelection();
350 }
346 } else { 351 } else {
347 HTMLTextFormControlElement::updateFocusAppearance(selectionBehavior); 352 HTMLTextFormControlElement::updateFocusAppearance(selectionBehavior);
348 } 353 }
349 } 354 }
350 355
351 void HTMLInputElement::beginEditing() 356 void HTMLInputElement::beginEditing()
352 { 357 {
353 DCHECK(document().isActive()); 358 DCHECK(document().isActive());
354 if (!document().isActive()) 359 if (!document().isActive())
355 return; 360 return;
(...skipping 1552 matching lines...) Expand 10 before | Expand all | Expand 10 after
1908 { 1913 {
1909 return m_inputTypeView->hasFallbackContent(); 1914 return m_inputTypeView->hasFallbackContent();
1910 } 1915 }
1911 1916
1912 void HTMLInputElement::setFilesFromPaths(const Vector<String>& paths) 1917 void HTMLInputElement::setFilesFromPaths(const Vector<String>& paths)
1913 { 1918 {
1914 return m_inputType->setFilesFromPaths(paths); 1919 return m_inputType->setFilesFromPaths(paths);
1915 } 1920 }
1916 1921
1917 } // namespace blink 1922 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelection.cpp ('k') | third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698