Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2326493004: Revert of Move HTMLDocument::isCaseSensitiveAttribute into SelectorChecker (Closed)

Created:
4 years, 3 months ago by foolip
Modified:
4 years, 3 months ago
Reviewers:
esprehn, rune
CC:
chromium-reviews, blink-reviews-css, blink-reviews-html_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move HTMLDocument::isCaseSensitiveAttribute into SelectorChecker (patchset #1 id:1 of https://codereview.chromium.org/2313253002/ ) Reason for revert: Possible cause of regression in blink_perf.parser. BUG=645370 Original issue's description: > Move HTMLDocument::isCaseSensitiveAttribute into SelectorChecker > > BUG=238368 > R=esprehn@chromium.org,rune@opera.com > > Committed: https://crrev.com/e912108e9daf83d1bec61e5b78aaacf965a3e2fc > Cr-Commit-Position: refs/heads/master@{#416903} TBR=esprehn@chromium.org,rune@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=238368 Committed: https://crrev.com/fac211fb17e55913cadfae4344f23b056066c7f6 Cr-Commit-Position: refs/heads/master@{#417571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -40 lines) Patch
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 2 chunks +4 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDocument.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDocument.cpp View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
foolip
Created Revert of Move HTMLDocument::isCaseSensitiveAttribute into SelectorChecker
4 years, 3 months ago (2016-09-09 11:43:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326493004/1
4 years, 3 months ago (2016-09-09 11:43:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 13:23:16 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 13:26:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fac211fb17e55913cadfae4344f23b056066c7f6
Cr-Commit-Position: refs/heads/master@{#417571}

Powered by Google App Engine
This is Rietveld 408576698