Adds missing and removes duplicate tracing macros.

Adds missing and removes duplicate tracing macros.

This fixes the missing tracing nested instant call without any arguments and
removes the duplicate of the one with 2 arguments.

BUG=645308
Committed: https://crrev.com/db476ca7de669dd97607ceeabf6f97fbc3201f1e
Cr-Commit-Position: refs/heads/master@{#417753}

[carlosk, 2016-09-09 00:21:36]

The CQ bit was checked by carlosk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 00:22:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[carlosk, 2016-09-09 00:26:16]

carlosk@chromium.org changed reviewers:
+ oysteine@chromium.org

[carlosk, 2016-09-09 00:26:16]

oysteine@: PTAL.

Hopefully this is the right thing to do.

[carlosk, 2016-09-09 00:27:12]

On 2016/09/09 00:26:16, carlosk wrote:
> oysteine@: PTAL.
> 
> Hopefully this is the right thing to do.

And FYI I also uploaded https://codereview.chromium.org/2321283002 to cover the
mirror macro file in the SKIA codebase.

[oystein (OOO til 10th of July), 2016-09-09 00:30:24]

https://codereview.chromium.org/2326483004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/TraceEventCommon.h (right):

https://codereview.chromium.org/2326483004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/TraceEventCommon.h:753: #define
TRACE_EVENT_NESTABLE_ASYNC_INSTANT0(category_group, name, id)        \
Are you adding this because you'll use it, or because it's missing? Typically we
haven't filled in all of the permutations of all the different macros due to
combinatorial explosion issues.

[carlosk, 2016-09-09 00:34:12]

https://codereview.chromium.org/2326483004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/TraceEventCommon.h (right):

https://codereview.chromium.org/2326483004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/TraceEventCommon.h:753: #define
TRACE_EVENT_NESTABLE_ASYNC_INSTANT0(category_group, name, id)        \
On 2016/09/09 00:30:24, oystein wrote:
> Are you adding this because you'll use it, or because it's missing? Typically
we
> haven't filled in all of the permutations of all the different macros due to
> combinatorial explosion issues.

Yes. :)

I'm adding new tracing calls to MHTMLGenerationManager and I wanted to add this
macro call (no CL uploaded yet). Otherwise I'd set a dummy value into that
single argument.

[oystein (OOO til 10th of July), 2016-09-09 00:37:33]

Great! lgtm :)

[carlosk, 2016-09-09 00:47:43]

On 2016/09/09 00:37:33, oystein wrote:
> Great! lgtm :)

Thanks!

One more question though: how should I proceed with the deploying of these two
related CLs? Is there a preferred ordering? Should both land as closely as
possible?

[fmeawad, 2016-09-09 00:48:42]

On 2016/09/09 00:47:43, carlosk wrote:
> On 2016/09/09 00:37:33, oystein wrote:
> > Great! lgtm :)
> 
> Thanks!
> 
> One more question though: how should I proceed with the deploying of these two
> related CLs? Is there a preferred ordering? Should both land as closely as
> possible?

It does not matter, usually we land chromium first.

[carlosk, 2016-09-09 00:51:52]

carlosk@chromium.org changed reviewers:
+ pfeldman@chromium.org

[carlosk, 2016-09-09 00:51:53]

pfeldman@: PTAL in the Blink file.

[commit-bot: I haz the power, 2016-09-09 03:16:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 03:16:08]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2016-09-09 23:03:02]

lgtm

[carlosk, 2016-09-09 23:05:12]

The CQ bit was checked by carlosk@chromium.org

[commit-bot: I haz the power, 2016-09-09 23:05:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 23:10:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-09 23:13:23]

Description was changed from

==========
Adds missing and removes duplicate tracing macros.

This fixes the missing tracing nested instant call without any arguments and
removes the duplicate of the one with 2 arguments.

BUG=645308
==========

to

==========
Adds missing and removes duplicate tracing macros.

This fixes the missing tracing nested instant call without any arguments and
removes the duplicate of the one with 2 arguments.

BUG=645308

Committed: https://crrev.com/db476ca7de669dd97607ceeabf6f97fbc3201f1e
Cr-Commit-Position: refs/heads/master@{#417753}
==========

[commit-bot: I haz the power, 2016-09-09 23:13:25]

Patchset 1 (id:??) landed as
https://crrev.com/db476ca7de669dd97607ceeabf6f97fbc3201f1e
Cr-Commit-Position: refs/heads/master@{#417753}