|
|
DescriptionAdds missing and removes duplicate tracing macros.
This fixes the missing tracing nested instant call without any arguments and
removes the duplicate of the one with 2 arguments.
This is a follow up on https://crrev.com/2326483004
BUG=645308
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321283002
NOPRESUBMIT=true
CQ_EXCLUDE_TRYBOTS=client.skia.fyi:skia_presubmit-Trybot
Committed: https://skia.googlesource.com/skia/+/4a56318d4c771de50194700083cc1acee0a66fa4
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
Description was changed from ========== Adds missing and removes duplicate tracing macros. This fixes the missing tracing nested instant call without any arguments and removes the duplicate of the one with 2 arguments. This is a follow up on https://crrev.com/2326483004 BUG=skia:645308 ========== to ========== Adds missing and removes duplicate tracing macros. This fixes the missing tracing nested instant call without any arguments and removes the duplicate of the one with 2 arguments. This is a follow up on https://crrev.com/2326483004 BUG=skia:645308 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321283002 ==========
The CQ bit was checked by carlosk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
carlosk@chromium.org changed reviewers: + reed@google.com
reed@: PTAL. On that hooks check failure: I don't know if I can avoid it and I don't think it's correct as this file doesn't include anything.
Description was changed from ========== Adds missing and removes duplicate tracing macros. This fixes the missing tracing nested instant call without any arguments and removes the duplicate of the one with 2 arguments. This is a follow up on https://crrev.com/2326483004 BUG=skia:645308 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321283002 ========== to ========== Adds missing and removes duplicate tracing macros. This fixes the missing tracing nested instant call without any arguments and removes the duplicate of the one with 2 arguments. This is a follow up on https://crrev.com/2326483004 BUG=645308 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321283002 ==========
lgtm
The CQ bit was checked by carlosk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
Description was changed from ========== Adds missing and removes duplicate tracing macros. This fixes the missing tracing nested instant call without any arguments and removes the duplicate of the one with 2 arguments. This is a follow up on https://crrev.com/2326483004 BUG=645308 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321283002 ========== to ========== Adds missing and removes duplicate tracing macros. This fixes the missing tracing nested instant call without any arguments and removes the duplicate of the one with 2 arguments. This is a follow up on https://crrev.com/2326483004 BUG=645308 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321283002 NOPRESUBMIT=true CQ_EXCLUDE_TRYBOTS=client.skia.fyi:skia_presubmit-Trybot ==========
The CQ bit was checked by carlosk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Adds missing and removes duplicate tracing macros. This fixes the missing tracing nested instant call without any arguments and removes the duplicate of the one with 2 arguments. This is a follow up on https://crrev.com/2326483004 BUG=645308 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321283002 NOPRESUBMIT=true CQ_EXCLUDE_TRYBOTS=client.skia.fyi:skia_presubmit-Trybot ========== to ========== Adds missing and removes duplicate tracing macros. This fixes the missing tracing nested instant call without any arguments and removes the duplicate of the one with 2 arguments. This is a follow up on https://crrev.com/2326483004 BUG=645308 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321283002 NOPRESUBMIT=true CQ_EXCLUDE_TRYBOTS=client.skia.fyi:skia_presubmit-Trybot Committed: https://skia.googlesource.com/skia/+/4a56318d4c771de50194700083cc1acee0a66fa4 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/4a56318d4c771de50194700083cc1acee0a66fa4 |