Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2321283002: Adds missing and removes duplicate tracing macros. (Closed)

Created:
4 years, 3 months ago by carlosk
Modified:
4 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Adds missing and removes duplicate tracing macros. This fixes the missing tracing nested instant call without any arguments and removes the duplicate of the one with 2 arguments. This is a follow up on https://crrev.com/2326483004 BUG=645308 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321283002 NOPRESUBMIT=true CQ_EXCLUDE_TRYBOTS=client.skia.fyi:skia_presubmit-Trybot Committed: https://skia.googlesource.com/skia/+/4a56318d4c771de50194700083cc1acee0a66fa4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/core/SkTraceEventCommon.h View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
carlosk
reed@: PTAL. On that hooks check failure: I don't know if I can avoid it ...
4 years, 3 months ago (2016-09-09 00:54:32 UTC) #7
reed1
lgtm
4 years, 3 months ago (2016-09-09 14:56:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321283002/1
4 years, 3 months ago (2016-09-09 23:05:35 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/13635)
4 years, 3 months ago (2016-09-09 23:07:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321283002/1
4 years, 3 months ago (2016-09-09 23:15:04 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 23:15:22 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4a56318d4c771de50194700083cc1acee0a66fa4

Powered by Google App Engine
This is Rietveld 408576698