Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 23264014: Bleed cleanup (remove nocolorbleed GM & enable bleed in game bench) (Closed)

Created:
7 years, 4 months ago by robertphillips
Modified:
7 years, 4 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

The bleed GM now subsumes everything the nocolorbleed GM used to do. Now that Ganesh fully supports the bleed flag I have enabled it in the atlased game bench. Here are the results (on Win7): BEFORE (TextureDomain) running bench [640 480] game_trans_full_atlas_drawVerts_aa GPU: cmsecs = 0.00 gmsecs = 9.44 running bench [640 480] game_trans_full_atlas_aa GPU: cmsecs = 15.60 gmsecs = 5.88 AFTER (bleed) running bench [640 480] game_trans_full_atlas_drawVerts_aa GPU: cmsecs = 0.00 gmsecs = 9.43 running bench [640 480] game_trans_full_atlas_aa GPU: cmsecs = 0.00 gmsecs = 5.21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -80 lines) Patch
M bench/GameBench.cpp View 1 chunk +2 lines, -1 line 0 comments Download
D gm/nocolorbleed.cpp View 1 chunk +0 lines, -78 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
robertphillips
7 years, 4 months ago (2013-08-20 17:23:30 UTC) #1
bsalomon
lgtm
7 years, 4 months ago (2013-08-21 12:54:18 UTC) #2
robertphillips
On Mac: BEFORE (TextureDomain) game_trans_full_atlas_drawVerts_aa GPU: msecs = 25.00 cmsecs = 24.03 gmsecs = 21.68 ...
7 years, 4 months ago (2013-08-21 16:27:04 UTC) #3
robertphillips
7 years, 4 months ago (2013-08-21 16:30:57 UTC) #4
Message was sent while issue was closed.
committed as r10853

Powered by Google App Engine
This is Rietveld 408576698