Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 2326203002: services/ui: Add WindowServerTestHelper. (Closed)

Created:
4 years, 3 months ago by sadrul
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

services/ui: Add WindowServerTestHelper. Refactor the code to initialize WindowServer, MessageLoop etc. in tests into WindowServerTestHelper so that it can be reused. BUG=none Committed: https://crrev.com/9d270b260c2363679f130741f8f0e5122c0bdd3b Cr-Commit-Position: refs/heads/master@{#418015}

Patch Set 1 #

Patch Set 2 : self nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -136 lines) Patch
M services/ui/ws/cursor_unittest.cc View 1 9 chunks +25 lines, -29 lines 0 comments Download
M services/ui/ws/display_unittest.cc View 7 chunks +47 lines, -51 lines 0 comments Download
M services/ui/ws/test_utils.h View 1 2 chunks +32 lines, -10 lines 0 comments Download
M services/ui/ws/test_utils.cc View 6 chunks +23 lines, -14 lines 0 comments Download
M services/ui/ws/user_display_manager_unittest.cc View 6 chunks +24 lines, -32 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
sadrul
4 years, 3 months ago (2016-09-10 01:02:04 UTC) #5
sadrul
The notable change in here is probably that ~WindowServerTestHelper explicitly destroys the WindowServer while the ...
4 years, 3 months ago (2016-09-10 01:06:30 UTC) #7
sky
LGTM
4 years, 3 months ago (2016-09-12 16:44:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326203002/20001
4 years, 3 months ago (2016-09-12 19:18:51 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-12 20:05:44 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 20:07:53 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d270b260c2363679f130741f8f0e5122c0bdd3b
Cr-Commit-Position: refs/heads/master@{#418015}

Powered by Google App Engine
This is Rietveld 408576698