Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2326093002: Fix color gamut xform matrices in GPU code (Closed)

Created:
4 years, 3 months ago by Brian Osman
Modified:
4 years, 3 months ago
Reviewers:
msarett, mtklein, bsalomon, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix color gamut xform matrices in GPU code Now that we're not storing them transposed, we can plumb them to the shader column-major all the way, and then multiply colors on the right, as it should be. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2326093002 Committed: https://skia.googlesource.com/skia/+/8d914908d8ad37a73c39ba8f7ef298bfee457388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/gpu/GrColorSpaceXform.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLShaderBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Brian Osman
4 years, 3 months ago (2016-09-09 18:04:20 UTC) #5
msarett
lgtm
4 years, 3 months ago (2016-09-09 18:07:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326093002/1
4 years, 3 months ago (2016-09-09 18:28:22 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 18:30:58 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8d914908d8ad37a73c39ba8f7ef298bfee457388

Powered by Google App Engine
This is Rietveld 408576698