Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2326063003: In LayoutTestResult, change is_missing_* methods to accept explicit False. (Closed)

Created:
4 years, 3 months ago by qyearsley
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, cbentzel+watch_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In LayoutTestResult, change is_missing_* methods to accept explicit False. This doesn't change any behavior in practice, since whenever is_missing_* is present in a layout test dict, it's always true, as far as I know. This change also changes did_run_as_expected. So, this is just a minor tweak for correctness in case those fields are ever explicitly given as False. Committed: https://crrev.com/57f8a91b6ca44aca59df7c39b8907e35d33bfaf5 Cr-Commit-Position: refs/heads/master@{#417967}

Patch Set 1 #

Patch Set 2 : Specify False as the default value. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py View 1 1 chunk +4 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
qyearsley
4 years, 3 months ago (2016-09-09 22:06:23 UTC) #2
Dirk Pranke
I'd probably add in the default 'False' values just to be slightly clearer. I don't ...
4 years, 3 months ago (2016-09-10 16:21:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326063003/20001
4 years, 3 months ago (2016-09-12 16:19:35 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-12 17:36:23 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 17:38:15 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57f8a91b6ca44aca59df7c39b8907e35d33bfaf5
Cr-Commit-Position: refs/heads/master@{#417967}

Powered by Google App Engine
This is Rietveld 408576698