Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py

Issue 2326063003: In LayoutTestResult, change is_missing_* methods to accept explicit False. (Closed)
Patch Set: Specify False as the default value. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py
index 50a3dd9c9eb1432365c27c1fd0d1e58bcdd049e3..ecb074aee902e0c580a573bc9110dc60a462e5df 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py
@@ -51,23 +51,16 @@ class LayoutTestResult(object):
return 'PASS' in self.actual_results()
def did_run_as_expected(self):
- # TODO(qyearsley): For correctness, this should be:
- # return not self._result_dict.get('is_unexpected', False)
- # (Right now for expected results it's not added to the result dict
- # but in theory it could be present.)
- return 'is_unexpected' not in self._result_dict
+ return not self._result_dict.get('is_unexpected', False)
def is_missing_image(self):
- # TODO(qyearsley): Change this to:
- # self._result_dict.get('is_missing_image', False)
- # The following method should likewise be changed.
- return 'is_missing_image' in self._result_dict
+ return self._result_dict.get('is_missing_image', False)
def is_missing_text(self):
- return 'is_missing_text' in self._result_dict
+ return self._result_dict.get('is_missing_text', False)
def is_missing_audio(self):
- return 'is_missing_audio' in self._result_dict
+ return self._result_dict.get('is_missing_audio', False)
def actual_results(self):
return self._result_dict['actual']
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698