Issue 232603002: Avoid maybe-uninitialized gcc warning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 232603002: Avoid maybe-uninitialized gcc warning. (Closed)

Created:
6 years, 8 months ago by sof

Modified:
6 years, 8 months ago

Reviewers:
yurys

CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Avoid maybe-uninitialized gcc warning. Add explicit initialization of local variable to avoid some versions of gcc warn about its potentially uninitialized use. R= BUG=349898

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/dom/CharacterData.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yurys

Oops, just noticed this CL. I've already landed exactly this fix: http://src.chromium.org/viewvc/blink?revision=171240&view=revision

6 years, 8 months ago (2014-04-10 07:45:56 UTC) #1

sof

6 years, 8 months ago (2014-04-10 07:49:33 UTC) #2

Problem solved, I hope, so all good. Closing.

I held off on publishing the CL as it wasn't clear what would help the Blink
roll more (cf. https://codereview.chromium.org/229793004/#msg6 )

Expand Messages | Collapse Messages