Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: third_party/WebKit/Source/core/editing/CaretBase.cpp

Issue 2325933002: Move m_caretVisibility from CaretBase to FrameCaret (Closed)
Patch Set: 2016-09-09T14:05:22 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/CaretBase.cpp
diff --git a/third_party/WebKit/Source/core/editing/CaretBase.cpp b/third_party/WebKit/Source/core/editing/CaretBase.cpp
index 0188054436a7db1bf507c3295b26105fc1349757..7bd13534b307dee4deb7b0c6316f590fadeb0513 100644
--- a/third_party/WebKit/Source/core/editing/CaretBase.cpp
+++ b/third_party/WebKit/Source/core/editing/CaretBase.cpp
@@ -42,11 +42,7 @@
namespace blink {
-CaretBase::CaretBase(CaretVisibility visibility)
- : m_caretVisibility(visibility)
-{
-}
-
+CaretBase::CaretBase() = default;
CaretBase::~CaretBase() = default;
DEFINE_TRACE(CaretBase)
@@ -193,9 +189,6 @@ void CaretBase::invalidateCaretRect(Node* node)
void CaretBase::paintCaret(Node* node, GraphicsContext& context, const LayoutPoint& paintOffset, DisplayItem::Type displayItemType) const
{
- if (m_caretVisibility == CaretVisibility::Hidden)
- return;
-
if (DrawingRecorder::useCachedDrawingIfPossible(context, *this, displayItemType))
return;
@@ -220,11 +213,6 @@ void CaretBase::paintCaret(Node* node, GraphicsContext& context, const LayoutPoi
context.fillRect(paintRect, caretColor);
}
-void CaretBase::setCaretVisibility(CaretVisibility visibility)
-{
- m_caretVisibility = visibility;
-}
-
String CaretBase::debugName() const
{
return "Caret";
« no previous file with comments | « third_party/WebKit/Source/core/editing/CaretBase.h ('k') | third_party/WebKit/Source/core/editing/DragCaretController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698