Chromium Code Reviews Chromium Code Reviews
Issue 2325883002:
Adds a 'Done' button at the end of hats survey (Closed)
| Index: chrome/browser/resources/chromeos/hats/hats.html |
| diff --git a/chrome/browser/resources/chromeos/hats/hats.html b/chrome/browser/resources/chromeos/hats/hats.html |
| index 6fcc35db87cc0fe05fb393cdd0c3a5aff9adfb1f..acd10a934d9429aa266fe5a983ffcf75ecce1688 100644 |
| --- a/chrome/browser/resources/chromeos/hats/hats.html |
| +++ b/chrome/browser/resources/chromeos/hats/hats.html |
| @@ -1,5 +1,19 @@ |
| <html> |
| <head> |
| + <style> |
| + .done-button { |
| + bottom: 17px; |
| + color: rgb(33, 150, 243); |
| + display: none; |
| + filter: none; |
| + font: 400 16px Roboto,RobotoDraft,Helvetica,sans-serif; |
| + position: fixed; |
| + right: 25px; |
|
xiyuan
2016/09/09 17:06:22
Do we need to worry about RTL?
malaykeshav
2016/09/09 18:00:32
As of now the survey is only in English.
|
| + text-shadow: none; |
| + text-transform: uppercase; |
| + z-index: 10; |
| + } |
| + </style> |
| <script> |
| /** |
| * Handles the callback when the survey is submitted or when the survey |
| @@ -12,10 +26,20 @@ |
| if (!isFirstRun) { |
| return; |
| } |
| - /* Resize the window to match the size of thank you message. */ |
| - window.resizeTo(400, 110); |
| + |
| + /* Display the done button at the end of the survey. */ |
| + document.getElementById('id-done-button').style.display = 'block'; |
| + }; |
| + |
| + var done = function() { |
| + window.close(); |
| }; |
| </script> |
| <script src="$SCRIPT_SRC"></script> |
| </head> |
| + <body> |
| + <a href="javascript:done()" role="button"> |
|
xiyuan
2016/09/09 17:06:22
Typically, we do something like this instead of in
malaykeshav
2016/09/09 18:00:32
Done
|
| + <div id="id-done-button" class="done-button">Done</div> |
|
xiyuan
2016/09/09 17:06:22
We should use a placeholder similar to what we did
malaykeshav
2016/09/09 18:00:32
Done
|
| + </a> |
| + </body> |
| </html> |
