Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2325833002: Handle frames sent from peer connection in VideoTrackRecorder (Closed)

Created:
4 years, 3 months ago by emircan
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Handle frames sent from peer connection in VideoTrackRecorder This CL changes the way we handle frames received from peer connection in VideoTrackRecorder. If we forward those frames directly to GPU process, they might not be accessible if they aren't backed by STORAGE_SHMEM. We need to copy those frames into new buffers for these cases. BUG=644526 TEST=Added new content_browsertest which fails before the changes. Review-Url: https://codereview.chromium.org/2315073002 Cr-Commit-Position: refs/heads/master@{#416983} (cherry picked from commit 83287174008c789d2e3ed450fa5e2a4236dd5040) NOTRY=true NOPRESUBMIT=true TBR=avi@chromium.org,mcasas@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M content/browser/webrtc/webrtc_media_recorder_browsertest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/renderer/media/video_track_recorder.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/test/data/media/mediarecorder_test.html View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325833002/1
4 years, 3 months ago (2016-09-08 23:14:17 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 23:48:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698