|
|
Chromium Code Reviews
DescriptionHandle frames sent from peer connection in VideoTrackRecorder
This CL changes the way we handle frames received from peer connection in
VideoTrackRecorder. If we forward those frames directly to GPU process, they
might not be accessible if they aren't backed by STORAGE_SHMEM. We need
to copy those frames into new buffers for these cases.
BUG=644526
TEST=Added new content_browsertest which fails before the changes.
Committed: https://crrev.com/83287174008c789d2e3ed450fa5e2a4236dd5040
Cr-Commit-Position: refs/heads/master@{#416983}
Patch Set 1 : #
Messages
Total messages: 25 (16 generated)
Description was changed from ========== vt rec BUG= ========== to ========== Handle frames sent from peer connection in VideoTrackRecorder BUG=644526 ==========
emircan@chromium.org changed reviewers: + mcasas@chromium.org
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Handle frames sent from peer connection in VideoTrackRecorder BUG=644526 ========== to ========== Handle frames sent from peer connection in VideoTrackRecorder This CL changes the way we handle frames received from peer connection in VideoTrackRecorder. If we forward those frames directly to GPU process, they might not be accessible if they aren't backed by STORAGE_SHMEM. We need to copy those frames into new buffers for these cases. BUG=644526 TEST=Added new content_browsertest which fails before the changes. ==========
Patchset #1 (id:1) has been deleted
PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
emircan@chromium.org changed reviewers: + avi@chromium.org
avi@chromium.org: Please RS review changes in content/browser/webrtc/webrtc_media_recorder_browsertest.cc
lgtm stampity stamp
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Handle frames sent from peer connection in VideoTrackRecorder This CL changes the way we handle frames received from peer connection in VideoTrackRecorder. If we forward those frames directly to GPU process, they might not be accessible if they aren't backed by STORAGE_SHMEM. We need to copy those frames into new buffers for these cases. BUG=644526 TEST=Added new content_browsertest which fails before the changes. ========== to ========== Handle frames sent from peer connection in VideoTrackRecorder This CL changes the way we handle frames received from peer connection in VideoTrackRecorder. If we forward those frames directly to GPU process, they might not be accessible if they aren't backed by STORAGE_SHMEM. We need to copy those frames into new buffers for these cases. BUG=644526 TEST=Added new content_browsertest which fails before the changes. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Handle frames sent from peer connection in VideoTrackRecorder This CL changes the way we handle frames received from peer connection in VideoTrackRecorder. If we forward those frames directly to GPU process, they might not be accessible if they aren't backed by STORAGE_SHMEM. We need to copy those frames into new buffers for these cases. BUG=644526 TEST=Added new content_browsertest which fails before the changes. ========== to ========== Handle frames sent from peer connection in VideoTrackRecorder This CL changes the way we handle frames received from peer connection in VideoTrackRecorder. If we forward those frames directly to GPU process, they might not be accessible if they aren't backed by STORAGE_SHMEM. We need to copy those frames into new buffers for these cases. BUG=644526 TEST=Added new content_browsertest which fails before the changes. Committed: https://crrev.com/83287174008c789d2e3ed450fa5e2a4236dd5040 Cr-Commit-Position: refs/heads/master@{#416983} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/83287174008c789d2e3ed450fa5e2a4236dd5040 Cr-Commit-Position: refs/heads/master@{#416983}
Message was sent while issue was closed.
Description was changed from ========== Handle frames sent from peer connection in VideoTrackRecorder This CL changes the way we handle frames received from peer connection in VideoTrackRecorder. If we forward those frames directly to GPU process, they might not be accessible if they aren't backed by STORAGE_SHMEM. We need to copy those frames into new buffers for these cases. BUG=644526 TEST=Added new content_browsertest which fails before the changes. Committed: https://crrev.com/83287174008c789d2e3ed450fa5e2a4236dd5040 Cr-Commit-Position: refs/heads/master@{#416983} ========== to ========== Handle frames sent from peer connection in VideoTrackRecorder This CL changes the way we handle frames received from peer connection in VideoTrackRecorder. If we forward those frames directly to GPU process, they might not be accessible if they aren't backed by STORAGE_SHMEM. We need to copy those frames into new buffers for these cases. BUG=644526 TEST=Added new content_browsertest which fails before the changes. Committed: https://crrev.com/83287174008c789d2e3ed450fa5e2a4236dd5040 Cr-Commit-Position: refs/heads/master@{#416983} NOTRY=true NOPRESUBMIT=true TBR=avi@chromium.org,mcasas@chromium.org ==========
Message was sent while issue was closed.
Description was changed from ========== Handle frames sent from peer connection in VideoTrackRecorder This CL changes the way we handle frames received from peer connection in VideoTrackRecorder. If we forward those frames directly to GPU process, they might not be accessible if they aren't backed by STORAGE_SHMEM. We need to copy those frames into new buffers for these cases. BUG=644526 TEST=Added new content_browsertest which fails before the changes. Committed: https://crrev.com/83287174008c789d2e3ed450fa5e2a4236dd5040 Cr-Commit-Position: refs/heads/master@{#416983} NOTRY=true NOPRESUBMIT=true TBR=avi@chromium.org,mcasas@chromium.org ========== to ========== Handle frames sent from peer connection in VideoTrackRecorder This CL changes the way we handle frames received from peer connection in VideoTrackRecorder. If we forward those frames directly to GPU process, they might not be accessible if they aren't backed by STORAGE_SHMEM. We need to copy those frames into new buffers for these cases. BUG=644526 TEST=Added new content_browsertest which fails before the changes. Committed: https://crrev.com/83287174008c789d2e3ed450fa5e2a4236dd5040 Cr-Commit-Position: refs/heads/master@{#416983} ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
