Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2315073002: Handle frames sent from peer connection in VideoTrackRecorder (Closed)

Created:
4 years, 3 months ago by emircan
Modified:
4 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle frames sent from peer connection in VideoTrackRecorder This CL changes the way we handle frames received from peer connection in VideoTrackRecorder. If we forward those frames directly to GPU process, they might not be accessible if they aren't backed by STORAGE_SHMEM. We need to copy those frames into new buffers for these cases. BUG=644526 TEST=Added new content_browsertest which fails before the changes. Committed: https://crrev.com/83287174008c789d2e3ed450fa5e2a4236dd5040 Cr-Commit-Position: refs/heads/master@{#416983}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M content/browser/webrtc/webrtc_media_recorder_browsertest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/renderer/media/video_track_recorder.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/test/data/media/mediarecorder_test.html View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
emircan
PTAL.
4 years, 3 months ago (2016-09-07 00:44:34 UTC) #7
mcasas
lgtm
4 years, 3 months ago (2016-09-07 16:07:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315073002/20001
4 years, 3 months ago (2016-09-07 17:07:58 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/254584)
4 years, 3 months ago (2016-09-07 17:14:17 UTC) #14
emircan
avi@chromium.org: Please RS review changes in content/browser/webrtc/webrtc_media_recorder_browsertest.cc
4 years, 3 months ago (2016-09-07 17:31:12 UTC) #16
Avi (use Gerrit)
lgtm stampity stamp
4 years, 3 months ago (2016-09-07 17:33:58 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315073002/20001
4 years, 3 months ago (2016-09-07 17:35:41 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-07 17:39:53 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 17:43:18 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83287174008c789d2e3ed450fa5e2a4236dd5040
Cr-Commit-Position: refs/heads/master@{#416983}

Powered by Google App Engine
This is Rietveld 408576698