Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac.

Split parts of //chrome/utility's BUILD.gn into //chrome/utility/safe_browsing/mac.

This also adds the crdmg target after fixing availability warnings.

BUG=645810
NOPRESUBMIT=true

Originally Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d
Reverted: https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877

Committed: https://crrev.com/a8abcd3183b56f96a99155ece7b6e13b56606c11
Cr-Commit-Position: refs/heads/master@{#418091}

[Robert Sesek, 2016-09-08 21:32:52]

The CQ bit was checked by rsesek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 21:33:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 21:40:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 21:40:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Robert Sesek, 2016-09-08 21:56:56]

The CQ bit was checked by rsesek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 21:57:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Robert Sesek, 2016-09-08 22:26:08]

rsesek@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-09-08 22:29:12]

https://codereview.chromium.org/2325783002/diff/20001/chrome/utility/safe_bro...
File chrome/utility/safe_browsing/mac/BUILD.gn (right):

https://codereview.chromium.org/2325783002/diff/20001/chrome/utility/safe_bro...
chrome/utility/safe_browsing/mac/BUILD.gn:53: cflags = [
"-Wno-partial-availability" ]
Fix the warnings instead?

https://codereview.chromium.org/2325783002/diff/20001/chrome/utility/safe_bro...
chrome/utility/safe_browsing/mac/BUILD.gn:56: executable("crdmg") {
Isn't that a new target? Advertise it in the cl description?

[Robert Sesek, 2016-09-08 22:43:05]

https://codereview.chromium.org/2325783002/diff/20001/chrome/utility/safe_bro...
File chrome/utility/safe_browsing/mac/BUILD.gn (right):

https://codereview.chromium.org/2325783002/diff/20001/chrome/utility/safe_bro...
chrome/utility/safe_browsing/mac/BUILD.gn:53: cflags = [
"-Wno-partial-availability" ]
On 2016/09/08 22:29:12, Nico wrote:
> Fix the warnings instead?

It's from openat() and mkdirat() which are 10.10+. We can't really express a
different deployment target for one-off executables. I could #pragma them in the
file.

https://codereview.chromium.org/2325783002/diff/20001/chrome/utility/safe_bro...
chrome/utility/safe_browsing/mac/BUILD.gn:56: executable("crdmg") {
On 2016/09/08 22:29:12, Nico wrote:
> Isn't that a new target? Advertise it in the cl description?

It's one I didn't port in the GN transition, since I knew I wanted to split this
out after the GYP files were axed.

[commit-bot: I haz the power, 2016-09-08 23:06:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 23:06:03]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-09-09 20:31:59]

https://codereview.chromium.org/2325783002/diff/20001/chrome/utility/safe_bro...
File chrome/utility/safe_browsing/mac/BUILD.gn (right):

https://codereview.chromium.org/2325783002/diff/20001/chrome/utility/safe_bro...
chrome/utility/safe_browsing/mac/BUILD.gn:53: cflags = [
"-Wno-partial-availability" ]
On 2016/09/08 22:43:05, Robert Sesek wrote:
> On 2016/09/08 22:29:12, Nico wrote:
> > Fix the warnings instead?
> 
> It's from openat() and mkdirat() which are 10.10+. We can't really express a
> different deployment target for one-off executables. I could #pragma them in
the
> file.

The warning just wants you to redeclare them, so that it knows you're aware
they're not on all platforms.

https://codereview.chromium.org/2325783002/diff/20001/chrome/utility/safe_bro...
chrome/utility/safe_browsing/mac/BUILD.gn:56: executable("crdmg") {
On 2016/09/08 22:43:05, Robert Sesek wrote:
> On 2016/09/08 22:29:12, Nico wrote:
> > Isn't that a new target? Advertise it in the cl description?
> 
> It's one I didn't port in the GN transition, since I knew I wanted to split
this
> out after the GYP files were axed.

I'm just saying you should mention that in the CL description since else this'll
look like it's just moving stuff around in `git log`

[Robert Sesek, 2016-09-09 20:41:06]

Description was changed from

==========
Split parts of //chrome/utility's BUILD.gn into
//chrome/utility/safe_browsing/mac.

BUG=none
==========

to

==========
Split parts of //chrome/utility's BUILD.gn into
//chrome/utility/safe_browsing/mac.

This also adds the crdmg target after fixing availability warnings.

BUG=none
==========

[Robert Sesek, 2016-09-09 20:43:25]

The CQ bit was checked by rsesek@chromium.org to run a CQ dry run

[Robert Sesek, 2016-09-09 20:44:01]

https://codereview.chromium.org/2325783002/diff/20001/chrome/utility/safe_bro...
File chrome/utility/safe_browsing/mac/BUILD.gn (right):

https://codereview.chromium.org/2325783002/diff/20001/chrome/utility/safe_bro...
chrome/utility/safe_browsing/mac/BUILD.gn:53: cflags = [
"-Wno-partial-availability" ]
On 2016/09/09 20:31:59, Nico wrote:
> On 2016/09/08 22:43:05, Robert Sesek wrote:
> > On 2016/09/08 22:29:12, Nico wrote:
> > > Fix the warnings instead?
> > 
> > It's from openat() and mkdirat() which are 10.10+. We can't really express a
> > different deployment target for one-off executables. I could #pragma them in
> the
> > file.
> 
> The warning just wants you to redeclare them, so that it knows you're aware
> they're not on all platforms.

Do'h, done.

https://codereview.chromium.org/2325783002/diff/20001/chrome/utility/safe_bro...
chrome/utility/safe_browsing/mac/BUILD.gn:56: executable("crdmg") {
On 2016/09/09 20:31:58, Nico wrote:
> On 2016/09/08 22:43:05, Robert Sesek wrote:
> > On 2016/09/08 22:29:12, Nico wrote:
> > > Isn't that a new target? Advertise it in the cl description?
> > 
> > It's one I didn't port in the GN transition, since I knew I wanted to split
> this
> > out after the GYP files were axed.
> 
> I'm just saying you should mention that in the CL description since else
this'll
> look like it's just moving stuff around in `git log`

Done.

[commit-bot: I haz the power, 2016-09-09 20:44:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-09-09 20:45:44]

lgtm, thanks!

https://codereview.chromium.org/2325783002/diff/40001/chrome/utility/safe_bro...
File chrome/utility/safe_browsing/mac/crdmg.cc (right):

https://codereview.chromium.org/2325783002/diff/40001/chrome/utility/safe_bro...
chrome/utility/safe_browsing/mac/crdmg.cc:28: extern "C" {
Maybe add some `// This executable is only supposed to work on 10.10+, so
unconditionally use these functions` type comment

[Robert Sesek, 2016-09-09 20:47:28]

https://codereview.chromium.org/2325783002/diff/40001/chrome/utility/safe_bro...
File chrome/utility/safe_browsing/mac/crdmg.cc (right):

https://codereview.chromium.org/2325783002/diff/40001/chrome/utility/safe_bro...
chrome/utility/safe_browsing/mac/crdmg.cc:28: extern "C" {
On 2016/09/09 20:45:44, Nico wrote:
> Maybe add some `// This executable is only supposed to work on 10.10+, so
> unconditionally use these functions` type comment

Done.

[Robert Sesek, 2016-09-09 20:48:24]

Description was changed from

==========
Split parts of //chrome/utility's BUILD.gn into
//chrome/utility/safe_browsing/mac.

This also adds the crdmg target after fixing availability warnings.

BUG=none
==========

to

==========
Split parts of //chrome/utility's BUILD.gn into
//chrome/utility/safe_browsing/mac.

This also adds the crdmg target after fixing availability warnings.

BUG=none
NOPRESUBMIT=true
==========

[Robert Sesek, 2016-09-09 20:48:29]

The CQ bit was checked by rsesek@chromium.org

[Robert Sesek, 2016-09-09 20:48:29]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2325783002/#ps60001
(title: "comment")

[commit-bot: I haz the power, 2016-09-09 20:49:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 21:57:52]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-09 21:59:58]

Description was changed from

==========
Split parts of //chrome/utility's BUILD.gn into
//chrome/utility/safe_browsing/mac.

This also adds the crdmg target after fixing availability warnings.

BUG=none
NOPRESUBMIT=true
==========

to

==========
Split parts of //chrome/utility's BUILD.gn into
//chrome/utility/safe_browsing/mac.

This also adds the crdmg target after fixing availability warnings.

BUG=none
NOPRESUBMIT=true

Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d
Cr-Commit-Position: refs/heads/master@{#417725}
==========

[commit-bot: I haz the power, 2016-09-09 21:59:59]

Patchset 4 (id:??) landed as
https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d
Cr-Commit-Position: refs/heads/master@{#417725}

[mmoroz, 2016-09-11 10:12:03]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2334503002/ by mmoroz@chromium.org.

The reason for reverting is: This CL had broken libFuzzer build for Mac :(
Filed crbug.com/645810.

[Robert Sesek, 2016-09-12 21:38:34]

Description was changed from

==========
Split parts of //chrome/utility's BUILD.gn into
//chrome/utility/safe_browsing/mac.

This also adds the crdmg target after fixing availability warnings.

BUG=none
NOPRESUBMIT=true

Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d
Cr-Commit-Position: refs/heads/master@{#417725}
==========

to

==========
Split parts of //chrome/utility's BUILD.gn into
//chrome/utility/safe_browsing/mac.

This also adds the crdmg target after fixing availability warnings.

BUG=none
NOPRESUBMIT=true

Originally Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d
Reverted: https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877
Cr-Commit-Position: refs/heads/master@{#417725}
==========

[Robert Sesek, 2016-09-12 21:40:40]

On 2016/09/11 10:12:03, mmoroz wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/2334503002/ by mailto:mmoroz@chromium.org.
> 
> The reason for reverting is: This CL had broken libFuzzer build for Mac :(
> Filed crbug.com/645810.

Bah, sorry for the breakage. Latest patch set will fix.

[Robert Sesek, 2016-09-12 21:40:52]

Description was changed from

==========
Split parts of //chrome/utility's BUILD.gn into
//chrome/utility/safe_browsing/mac.

This also adds the crdmg target after fixing availability warnings.

BUG=none
NOPRESUBMIT=true

Originally Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d
Reverted: https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877
Cr-Commit-Position: refs/heads/master@{#417725}
==========

to

==========
Split parts of //chrome/utility's BUILD.gn into
//chrome/utility/safe_browsing/mac.

This also adds the crdmg target after fixing availability warnings.

BUG=645810
NOPRESUBMIT=true

Originally Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d
Reverted: https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877
==========

[Robert Sesek, 2016-09-12 21:41:58]

The CQ bit was checked by rsesek@chromium.org

[Robert Sesek, 2016-09-12 21:41:58]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2325783002/#ps80001
(title: "Fix gn --check")

[commit-bot: I haz the power, 2016-09-12 21:42:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 23:00:21]

Description was changed from

==========
Split parts of //chrome/utility's BUILD.gn into
//chrome/utility/safe_browsing/mac.

This also adds the crdmg target after fixing availability warnings.

BUG=645810
NOPRESUBMIT=true

Originally Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d
Reverted: https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877
==========

to

==========
Split parts of //chrome/utility's BUILD.gn into
//chrome/utility/safe_browsing/mac.

This also adds the crdmg target after fixing availability warnings.

BUG=645810
NOPRESUBMIT=true

Originally Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d
Reverted: https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877
==========

[commit-bot: I haz the power, 2016-09-12 23:00:22]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-12 23:03:13]

Description was changed from

==========
Split parts of //chrome/utility's BUILD.gn into
//chrome/utility/safe_browsing/mac.

This also adds the crdmg target after fixing availability warnings.

BUG=645810
NOPRESUBMIT=true

Originally Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d
Reverted: https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877
==========

to

==========
Split parts of //chrome/utility's BUILD.gn into
//chrome/utility/safe_browsing/mac.

This also adds the crdmg target after fixing availability warnings.

BUG=645810
NOPRESUBMIT=true

Originally Committed: https://crrev.com/a2783c22659863b5cc5cf635eb13d5eb04f3603d
Reverted: https://crrev.com/1cb270778f6337af7b5b61e70b9d78d99b2e8877

Committed: https://crrev.com/a8abcd3183b56f96a99155ece7b6e13b56606c11
Cr-Commit-Position: refs/heads/master@{#418091}
==========

[commit-bot: I haz the power, 2016-09-12 23:03:14]

Patchset 5 (id:??) landed as
https://crrev.com/a8abcd3183b56f96a99155ece7b6e13b56606c11
Cr-Commit-Position: refs/heads/master@{#418091}