Fix bug in AOT compiler where we would propogate a result type for instances calls where the target…

Fix bug in AOT compiler where we would propogate a result type for instances calls where the target is not known.

Interacted with cid range checks to incorrectly reduce

foo(x) => (x * 1.0) is double;

to

foo(x) { x * 1.0; return true; }

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/1bc2b0419806d8118951e7d3eed23edcb5083938

[rmacnak, 2016-09-08 20:40:06]

rmacnak@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-09-08 20:53:53]

Lgtm w/comment

https://chromiumcodereview.appspot.com/2325753002/diff/1/runtime/vm/intermedi...
File runtime/vm/intermediate_language.cc (right):

https://chromiumcodereview.appspot.com/2325753002/diff/1/runtime/vm/intermedi...
runtime/vm/intermediate_language.cc:3201: if (FLAG_precompiled_mode &&
with_checks()) return false;
This function seems only used when finding inlining candidates. Maybe it should
be moved as is to ICData::HasOnlyDispatcherTargets() instead? Then it would not
depend on with_checks and FLAG_precompiled_mode.

[rmacnak, 2016-09-08 21:33:40]

https://codereview.chromium.org/2325753002/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/2325753002/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language.cc:3201: if (FLAG_precompiled_mode &&
with_checks()) return false;
On 2016/09/08 20:53:53, Florian Schneider wrote:
> This function seems only used when finding inlining candidates. Maybe it
should
> be moved as is to ICData::HasOnlyDispatcherTargets() instead? Then it would
not
> depend on with_checks and FLAG_precompiled_mode.

Done.

[rmacnak, 2016-09-08 21:36:32]

Description was changed from

==========
Fix bug in AOT compiler where we would propogate a result type for instances
calls where the target is not known.

Interacted with cid range checks to incorrectly reduce

foo(x) => (x * 1.0) is double;

to

foo(x) { x * 1.0; return true; }
==========

to

==========
Fix bug in AOT compiler where we would propogate a result type for instances
calls where the target is not known.

Interacted with cid range checks to incorrectly reduce

foo(x) => (x * 1.0) is double;

to

foo(x) { x * 1.0; return true; }

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1bc2b0419806d8118951e7d3eed23edcb5083938
==========

[rmacnak, 2016-09-08 21:36:33]

Committed patchset #2 (id:20001) manually as
1bc2b0419806d8118951e7d3eed23edcb5083938 (presubmit successful).