Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1359)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 2325753002: Fix bug in AOT compiler where we would propogate a result type for instances calls where the target… (Closed)
Patch Set: review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc
index 20b876e0257912444917573344e6ea6782e93a80..ab7c878e846a2b9d1be3bdb19ac5608f1ed6a5f1 100644
--- a/runtime/vm/intermediate_language.cc
+++ b/runtime/vm/intermediate_language.cc
@@ -3188,6 +3188,8 @@ void InstanceCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
bool PolymorphicInstanceCallInstr::HasSingleRecognizedTarget() const {
+ if (FLAG_precompiled_mode && with_checks()) return false;
+
return ic_data().HasOneTarget() &&
(MethodRecognizer::RecognizeKind(
Function::Handle(ic_data().GetTargetAt(0))) !=
@@ -3195,18 +3197,6 @@ bool PolymorphicInstanceCallInstr::HasSingleRecognizedTarget() const {
}
-bool PolymorphicInstanceCallInstr::HasOnlyDispatcherTargets() const {
- for (intptr_t i = 0; i < ic_data().NumberOfChecks(); ++i) {
- const Function& target = Function::Handle(ic_data().GetTargetAt(i));
- if (!target.IsNoSuchMethodDispatcher() &&
- !target.IsInvokeFieldDispatcher()) {
- return false;
- }
- }
- return true;
-}
-
-
// DBC does not support optimizing compiler and thus doesn't emit
// PolymorphicInstanceCallInstr.
#if !defined(TARGET_ARCH_DBC)
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698