Subzero, MIPS32: Intrinsic calls for ABS.fmt and SQRT.fmt

Subzero, MIPS32: Intrinsic calls for ABS.fmt and SQRT.fmt

This patch adds ABS.fmt and SQRT.fmt instructions for intrinsic
calls. Test cases are copied from nacl-other-intrinsics.ll.

R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=53d05686cb32767239467b4f52811d30165b12ae

[obucinac, 2016-09-08 17:16:43]

Description was changed from

==========
Subzero, MIPS32: Intrinsic calls for ABS.fmt and SQRT.fmt

This patch adds ABS.fmt and SQRT.fmt instructions for intrinsic
calls. Test cases are copied from nacl-other-intrinsics.ll.
==========

to

==========
Subzero, MIPS32: Intrinsic calls for ABS.fmt and SQRT.fmt

This patch adds ABS.fmt and SQRT.fmt instructions for intrinsic
calls. Test cases are copied from nacl-other-intrinsics.ll.
==========

[obucinac, 2016-09-08 17:16:43]

obucinac@gmail.com changed reviewers:
+ eholk@chromium.org, jaydeep.patil@imgtec.com, jpp@chromium.org,
kschimpf@google.com, sagar.thakur@imgtec.com, stichnot@chromium.org

[obucinac, 2016-09-08 17:18:40]

Test cases are copied from nacl-other-intrinsics.ll to make smaller, mips only,
test case, because I was getting errors when I tried to make tests in original
file.

[Jim Stichnoth, 2016-09-09 17:12:41]

https://codereview.chromium.org/2325703002/diff/20001/src/IceTargetLoweringMI...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/2325703002/diff/20001/src/IceTargetLoweringMI...
src/IceTargetLoweringMIPS32.cpp:2177: Type DestTy = (Dest != nullptr) ?
Dest->getType() : IceType_void;
I would do it more like this:

  const Type DestTy = (Dest == nullptr) ? IceType_void : Dest->getType();

https://codereview.chromium.org/2325703002/diff/20001/tests_lit/llvm2ice_test...
File tests_lit/llvm2ice_tests/nacl-other-intrinsics-mips.ll (right):

https://codereview.chromium.org/2325703002/diff/20001/tests_lit/llvm2ice_test...
tests_lit/llvm2ice_tests/nacl-other-intrinsics-mips.ll:27: define internal float
@test_sqrt_float_mergeable_load(float %x, i32 %iptr) {
Do you need these "mergeable_load" tests?

I think this was probably part of x86 tests where it's possible to fold a memory
load into the sqrt instruction operand.  But this is probably not available on
mips, and even if so, only available in O2 mode whereas this test only runs Om1.

[obucinac, 2016-09-09 17:39:40]

O2 test added for ignoring double unused SQRT

https://codereview.chromium.org/2325703002/diff/20001/src/IceTargetLoweringMI...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/2325703002/diff/20001/src/IceTargetLoweringMI...
src/IceTargetLoweringMIPS32.cpp:2177: Type DestTy = (Dest != nullptr) ?
Dest->getType() : IceType_void;
On 2016/09/09 17:12:41, stichnot wrote:
> I would do it more like this:
> 
>   const Type DestTy = (Dest == nullptr) ? IceType_void : Dest->getType();

Done.

https://codereview.chromium.org/2325703002/diff/20001/tests_lit/llvm2ice_test...
File tests_lit/llvm2ice_tests/nacl-other-intrinsics-mips.ll (right):

https://codereview.chromium.org/2325703002/diff/20001/tests_lit/llvm2ice_test...
tests_lit/llvm2ice_tests/nacl-other-intrinsics-mips.ll:27: define internal float
@test_sqrt_float_mergeable_load(float %x, i32 %iptr) {
On 2016/09/09 17:12:41, stichnot wrote:
> Do you need these "mergeable_load" tests?
> 
> I think this was probably part of x86 tests where it's possible to fold a
memory
> load into the sqrt instruction operand.  But this is probably not available on
> mips, and even if so, only available in O2 mode whereas this test only runs
Om1.

Removed

[Jim Stichnoth, 2016-09-10 15:25:20]

lgtm

[Jim Stichnoth, 2016-09-10 15:25:40]

Description was changed from

==========
Subzero, MIPS32: Intrinsic calls for ABS.fmt and SQRT.fmt

This patch adds ABS.fmt and SQRT.fmt instructions for intrinsic
calls. Test cases are copied from nacl-other-intrinsics.ll.
==========

to

==========
Subzero, MIPS32: Intrinsic calls for ABS.fmt and SQRT.fmt

This patch adds ABS.fmt and SQRT.fmt instructions for intrinsic
calls. Test cases are copied from nacl-other-intrinsics.ll.

R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-09-10 15:25:41]

Committed patchset #3 (id:40001) manually as
53d05686cb32767239467b4f52811d30165b12ae (presubmit successful).