Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/BUILD.gn

Issue 2325583002: Revert of [Bindings] Remove aggregation of generated binding code (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/modules/v8/BUILD.gn
diff --git a/third_party/WebKit/Source/bindings/modules/v8/BUILD.gn b/third_party/WebKit/Source/bindings/modules/v8/BUILD.gn
index 3b658a4710db522659c69d4209910a74776a2754..4da3e425bb39ea306be33e25a8fdfb5253d3dbbc 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/BUILD.gn
+++ b/third_party/WebKit/Source/bindings/modules/v8/BUILD.gn
@@ -13,13 +13,24 @@
group("bindings_modules_generated") {
public_deps = [
":bindings_modules_impl_generated",
+ ":bindings_modules_v8_generated_aggregate",
+ ":bindings_modules_v8_generated_individual",
":bindings_modules_v8_generated_init_partial",
- ":generate_bindings_modules_v8_interfaces",
- ":generate_bindings_modules_v8_partial_interfaces",
+ ":bindings_modules_v8_generated_partial_aggregate",
+ ":bindings_modules_v8_generated_partial_individual",
]
}
-idl_compiler("generate_bindings_modules_v8_interfaces") {
+# bindings_modules_generated_aggregate in modules/v8/generated.gyp
+aggregate_generated_bindings("bindings_modules_v8_generated_aggregate") {
+ sources = modules_definition_idl_files
+ component_dir = "modules"
+ is_partial = false
+ outputs = bindings_modules_generated_aggregate_files
+}
+
+# bindings_modules_generated_individual in modules/v8/generated.gyp
+idl_compiler("bindings_modules_v8_generated_individual") {
# Note in GYP this is modules_interface_idl_files but this variable is just
# defined to modules_definition_idl_files.
sources = modules_definition_idl_files
@@ -28,6 +39,7 @@
target_component = "modules"
}
+# bindings_modules_impl_generated in modules/v8/generated.gyp
idl_impl("bindings_modules_impl_generated") {
sources = modules_dictionary_idl_files
outputs = bindings_modules_generated_union_type_files +
@@ -36,7 +48,8 @@
target_component = "modules"
}
-idl_compiler("generate_bindings_modules_v8_partial_interfaces") {
+# bindings_modules_generated_individual in modules/v8/generated.gyp
+idl_compiler("bindings_modules_v8_generated_partial_individual") {
# Note in GYP this is modules_interface_idl_files but this variable is just
# defined to modules_definition_idl_files.
sources = core_idl_with_modules_dependency_files +
@@ -44,6 +57,15 @@
output_dir = bindings_modules_v8_output_dir
output_name_suffix = "Partial"
target_component = "modules"
+}
+
+# bindings_modules_generated_aggregate in modules/v8/generated.gyp
+aggregate_generated_bindings(
+ "bindings_modules_v8_generated_partial_aggregate") {
+ sources = core_idl_with_modules_dependency_files
+ component_dir = "modules"
+ is_partial = true
+ outputs = bindings_modules_generated_partial_aggregate_files
}
# GYP version: Source/bindings/modules/v8/generated.gyp:bindings_modules_v8_generated_init_partial
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/BUILD.gn ('k') | third_party/WebKit/Source/bindings/modules/v8/generated.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698