Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc

Issue 2325563005: s/Value/value/g for type trait value field in WebGLImageConversion.cpp (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc b/tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc
index faef4ec41c625661bd115cd8c9e2a05783d75349..3bf426f133d6274a0e3182a415cae8e8483d6e16 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc
@@ -94,6 +94,12 @@ class TypeTrait2<void> {
static const bool value = false;
};
+// We don't want to rewrite fields in type traits
+// (i.e. the |Value| -> |kValue| rename is undesirable below).
+struct TypeTrait3 {
+ static const bool Value = true;
danakj 2016/09/09 00:07:40 shouldn't it be |value| ?
danakj 2016/09/09 00:08:31 Maybe we should just change these to lowercase up
Łukasz Anforowicz 2016/09/09 16:55:46 Good point. I've tried to look for other cases of
+};
+
// Some type traits have static methods. We should not perform
// a |value| -> |kValue| rename in the type trait below.
template <typename T, typename U>

Powered by Google App Engine
This is Rietveld 408576698