s/Value/value/g for type trait value field in WebGLImageConversion.cpp

tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 namespace blink {
 
 // Note: do not add any copy or move constructors to this class: doing so will
 // break test coverage that we don't clobber the class name by trying to emit
 // replacements for synthesized functions.
 class C {
@@ skipping 76 matching lines @@
 class TypeTrait2 {
  public:
   static const bool value = false;
 };
 template <>
 class TypeTrait2<void> {
  public:
   static const bool value = false;
 };
 
+// We don't want to rewrite fields in type traits
+// (i.e. the |Value| -> |kValue| rename is undesirable below).
+struct TypeTrait3 {
+  static const bool Value = true;

[danakj, 2016/09/09 00:07:40]

shouldn't it be |value| ?

[danakj, 2016/09/09 00:08:31]

Maybe we should just change these to lowercase up front and then it works? I
think that matches most other type traits?

[Łukasz Anforowicz, 2016/09/09 16:55:46]

Good point.  I've tried to look for other cases of |Value| static field under
blink and is seems that platform/graphics/gpu/WebGLImageConversion.cpp is the
only case.

+};
+
 // Some type traits have static methods.  We should not perform
 // a |value| -> |kValue| rename in the type trait below.
 template <typename T, typename U>
 struct IsSubclass {
  private:
   typedef char YesType;
   struct NoType {
     char padding[8];
   };
 
@@ skipping 44 matching lines @@
   // Test that references to a static field are correctly rewritten.
   blink::C::instance_count_++;
   // Force instantiation of a copy constructor for blink::C to make sure field
   // initializers for synthesized functions don't cause weird rewrites.
   blink::C c;
   blink::C c2 = c;
 
   bool b1 = WTF::TypeTrait1::value;
   bool b2 = WTF::TypeTrait2<void>::value;
 }