Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 2325543002: [Fetch API] Call endRead sooner to avoid recursive invocation (Closed)

Created:
4 years, 3 months ago by yhirano
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Fetch API] Call endRead sooner to avoid recursive invocation Currently FetchDataConsumerHandle::Reader::endRead is called after ReadableStreamController::enqueue that can trigger a pull operation. This CL removes such a recursion by calling endRead before enqueue. BUG=644117 Review-Url: https://codereview.chromium.org/2311063003 Cr-Commit-Position: refs/heads/master@{#416723} (cherry picked from commit 561ffb5dd08c8f4af6d33f1caf0ce66ba38f397d) Committed: https://chromium.googlesource.com/chromium/src/+/a356d611880d6825ed8961523fc2c8c54bcc3a30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/stream-reader.js View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
yhirano
4 years, 3 months ago (2016-09-08 04:04:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a356d611880d6825ed8961523fc2c8c54bcc3a30.

Powered by Google App Engine
This is Rietveld 408576698