[Fetch API] Call endRead sooner to avoid recursive invocation

[Fetch API] Call endRead sooner to avoid recursive invocation

Currently FetchDataConsumerHandle::Reader::endRead is called after
ReadableStreamController::enqueue that can trigger a pull operation.

This CL removes such a recursion by calling endRead before enqueue.

BUG=644117
Committed: https://crrev.com/561ffb5dd08c8f4af6d33f1caf0ce66ba38f397d
Cr-Commit-Position: refs/heads/master@{#416723}

[yhirano, 2016-09-06 04:38:41]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 04:38:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-06 04:39:05]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 04:39:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 05:58:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 05:58:40]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-09-06 06:00:07]

Description was changed from

==========
[Fetch API] Call endRead sooner to avoid recursive invocation

Currently FetchDataConsumerHandle::Reader::endRead is called after
ReadableStreamController::enqueue that can trigger another pull operation.

This CL removes such recursion by calling endRead before enqueue.

BUG=644117
==========

to

==========
[Fetch API] Call endRead sooner to avoid recursive invocation

Currently FetchDataConsumerHandle::Reader::endRead is called after
ReadableStreamController::enqueue that can trigger another pull operation.

This CL removes such a recursion by calling endRead before enqueue.

BUG=644117
==========

[yhirano, 2016-09-06 06:00:23]

Description was changed from

==========
[Fetch API] Call endRead sooner to avoid recursive invocation

Currently FetchDataConsumerHandle::Reader::endRead is called after
ReadableStreamController::enqueue that can trigger another pull operation.

This CL removes such a recursion by calling endRead before enqueue.

BUG=644117
==========

to

==========
[Fetch API] Call endRead sooner to avoid recursive invocation

Currently FetchDataConsumerHandle::Reader::endRead is called after
ReadableStreamController::enqueue that can trigger a pull operation.

This CL removes such a recursion by calling endRead before enqueue.

BUG=644117
==========

[yhirano, 2016-09-06 06:00:40]

yhirano@chromium.org changed reviewers:
+ tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-09-06 06:31:14]

lgtm

is this happening in a context starting from didGetReadable()? for pull
invocation, we have [[pulling]] guard.

[yhirano, 2016-09-06 08:36:04]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 08:36:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-06 08:39:35]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 08:39:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-06 09:00:55]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 09:01:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-06 09:17:32]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 09:17:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-06 09:18:24]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 09:18:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-06 09:19:24]

On 2016/09/06 06:31:14, tyoshino wrote:
> lgtm
> 
> is this happening in a context starting from didGetReadable()? for pull
> invocation, we have [[pulling]] guard.

Yes.

I added a test and fixes a timeout bug. Can you take a look again?

Thanks,

[commit-bot: I haz the power, 2016-09-06 10:36:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 10:36:30]

Dry run: This issue passed the CQ dry run.

[tyoshino (SeeGerritForStatus), 2016-09-06 10:58:06]

lgtm

https://codereview.chromium.org/2311063003/diff/120001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/stream-reader.js
(right):

https://codereview.chromium.org/2311063003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/stream-reader.js:42:
let body;
body no longer need to be declared outside?

https://codereview.chromium.org/2311063003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/stream-reader.js:44:
body = res.body;
ah, this line itself is no longer needed.

[yhirano, 2016-09-06 11:01:23]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 11:01:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-09-06 11:03:08]

https://codereview.chromium.org/2311063003/diff/120001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/stream-reader.js
(right):

https://codereview.chromium.org/2311063003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/stream-reader.js:42:
let body;
On 2016/09/06 10:58:06, tyoshino wrote:
> body no longer need to be declared outside?

Done.

https://codereview.chromium.org/2311063003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/stream-reader.js:44:
body = res.body;
On 2016/09/06 10:58:06, tyoshino wrote:
> ah, this line itself is no longer needed.

Done.

[yhirano, 2016-09-06 11:03:13]

The CQ bit was unchecked by yhirano@chromium.org

[yhirano, 2016-09-06 11:03:18]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-09-06 11:03:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org
Link to the patchset: https://codereview.chromium.org/2311063003/#ps140001
(title: "fix")

[commit-bot: I haz the power, 2016-09-06 11:03:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 15:06:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 15:06:31]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yhirano, 2016-09-06 17:41:25]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-09-06 17:42:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 20:51:45]

Description was changed from

==========
[Fetch API] Call endRead sooner to avoid recursive invocation

Currently FetchDataConsumerHandle::Reader::endRead is called after
ReadableStreamController::enqueue that can trigger a pull operation.

This CL removes such a recursion by calling endRead before enqueue.

BUG=644117
==========

to

==========
[Fetch API] Call endRead sooner to avoid recursive invocation

Currently FetchDataConsumerHandle::Reader::endRead is called after
ReadableStreamController::enqueue that can trigger a pull operation.

This CL removes such a recursion by calling endRead before enqueue.

BUG=644117
==========

[commit-bot: I haz the power, 2016-09-06 20:51:46]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-09-06 20:55:25]

Description was changed from

==========
[Fetch API] Call endRead sooner to avoid recursive invocation

Currently FetchDataConsumerHandle::Reader::endRead is called after
ReadableStreamController::enqueue that can trigger a pull operation.

This CL removes such a recursion by calling endRead before enqueue.

BUG=644117
==========

to

==========
[Fetch API] Call endRead sooner to avoid recursive invocation

Currently FetchDataConsumerHandle::Reader::endRead is called after
ReadableStreamController::enqueue that can trigger a pull operation.

This CL removes such a recursion by calling endRead before enqueue.

BUG=644117

Committed: https://crrev.com/561ffb5dd08c8f4af6d33f1caf0ce66ba38f397d
Cr-Commit-Position: refs/heads/master@{#416723}
==========

[commit-bot: I haz the power, 2016-09-06 20:55:26]

Patchset 8 (id:??) landed as
https://crrev.com/561ffb5dd08c8f4af6d33f1caf0ce66ba38f397d
Cr-Commit-Position: refs/heads/master@{#416723}