Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2325473003: Support server-provided category names. (Closed)

Created:
4 years, 3 months ago by Michael van Ouwerkerk
Modified:
4 years, 3 months ago
Reviewers:
Marc Treib, tschumann
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, sfiera
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support server-provided category names. BUG=633613 patch from issue 2276383002 at patchset 40001 (http://crrev.com/2276383002#ps40001) Committed: https://crrev.com/3cd746d5eea880acbea5c4fd2a7550df94eedd9b Cr-Commit-Position: refs/heads/master@{#417289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -34 lines) Patch
M components/ntp_snippets/ntp_snippet.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/ntp_snippets/ntp_snippets_fetcher.h View 2 chunks +14 lines, -2 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_fetcher.cc View 5 chunks +29 lines, -14 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_fetcher_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.cc View 4 chunks +19 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Michael van Ouwerkerk
I'm continuing this CL from: https://codereview.chromium.org/2325473003 Please take a look!
4 years, 3 months ago (2016-09-08 13:04:26 UTC) #5
Michael van Ouwerkerk
I'm continuing this CL from: https://codereview.chromium.org/2325473003 Please take a look!
4 years, 3 months ago (2016-09-08 13:04:26 UTC) #6
Michael van Ouwerkerk
I'm continuing this CL from: https://codereview.chromium.org/2325473003 Please take a look!
4 years, 3 months ago (2016-09-08 13:04:27 UTC) #7
Marc Treib
LGTM (I only skimmed over it, assuming you didn't change anything major. When taking over ...
4 years, 3 months ago (2016-09-08 13:35:31 UTC) #8
Michael van Ouwerkerk
Thanks Marc :-) I only added a few comments and did the rebase on HEAD.
4 years, 3 months ago (2016-09-08 13:38:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325473003/1
4 years, 3 months ago (2016-09-08 14:31:54 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 14:36:12 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 14:38:16 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cd746d5eea880acbea5c4fd2a7550df94eedd9b
Cr-Commit-Position: refs/heads/master@{#417289}

Powered by Google App Engine
This is Rietveld 408576698