Issue 2325443002: git cl refactoring: "hide" non-public functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2325443002: git cl refactoring: "hide" non-public functions. (Closed)

Created:
4 years, 3 months ago by tandrii(chromium)

Modified:
4 years, 3 months ago

Reviewers:
iannucci

CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

git cl refactoring: "hide" non-public functions. R=iannucci@chromium.org BUG=642493

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	git_cl.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Depends on Patchset:

Total messages: 2 (2 generated)

tandrii(chromium)

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

4 years, 3 months ago (2016-09-07 22:25:16 UTC) #1

commit-bot: I haz the power

4 years, 3 months ago (2016-09-07 22:25:26 UTC) #2

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...