git_cl.py - Issue 2325443002: git cl refactoring: "hide" non-public functions. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1213)

My Issues | Starred Open | Closed | All

Unified Diff: git_cl.py

Issue 2325443002: git cl refactoring: "hide" non-public functions. (Closed)

Patch Set: yikes, no test coverage :( Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index a11004953222dad96fe29bbaf7cbefa72a78dac7..ff85f21e4599f4eda8ec15090ce87b004f84f02f 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -4277,7 +4277,7 @@ def SendUpstream(parser, args, cmd):

return 1 if killed else 0

-def WaitForRealCommit(remote, pushed_commit, local_base_ref, real_ref):

+def _WaitForRealCommit(remote, pushed_commit, local_base_ref, real_ref):

print()

print('Waiting for commit to be landed on %s...' % real_ref)

print('(If you are impatient, you may Ctrl-C once without harm)')

@@ -4304,7 +4304,7 @@ def WaitForRealCommit(remote, pushed_commit, local_base_ref, real_ref):

current_rev = to_rev

-def PushToGitPending(remote, pending_ref, upstream_ref):

+def _PushToGitPending(remote, pending_ref, upstream_ref):

"""Fetches pending_ref, cherry-picks current HEAD on top of it, pushes.

Returns:

« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698