Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 232533002: Rename PushInt64AsTwoSmis to PushRegisterAsTwoSmis and support x32 as well. (Closed)

Created:
6 years, 8 months ago by haitao.feng
Modified:
6 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Rename PushInt64AsTwoSmis to PushRegisterAsTwoSmis and support x32 as well. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M src/x64/debug-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
PTAL.
6 years, 8 months ago (2014-04-10 09:18:17 UTC) #1
Toon Verwaest
lgtm
6 years, 8 months ago (2014-04-10 14:34:46 UTC) #2
haitao.feng
6 years, 8 months ago (2014-04-11 02:03:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20662 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698