Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Side by Side Diff: src/x64/debug-x64.cc

Issue 232533002: Rename PushInt64AsTwoSmis to PushRegisterAsTwoSmis and support x32 as well. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 ASSERT((non_object_regs & ~kJSCallerSaved) == 0); 117 ASSERT((non_object_regs & ~kJSCallerSaved) == 0);
118 ASSERT((object_regs & non_object_regs) == 0); 118 ASSERT((object_regs & non_object_regs) == 0);
119 for (int i = 0; i < kNumJSCallerSaved; i++) { 119 for (int i = 0; i < kNumJSCallerSaved; i++) {
120 int r = JSCallerSavedCode(i); 120 int r = JSCallerSavedCode(i);
121 Register reg = { r }; 121 Register reg = { r };
122 ASSERT(!reg.is(kScratchRegister)); 122 ASSERT(!reg.is(kScratchRegister));
123 if ((object_regs & (1 << r)) != 0) { 123 if ((object_regs & (1 << r)) != 0) {
124 __ Push(reg); 124 __ Push(reg);
125 } 125 }
126 if ((non_object_regs & (1 << r)) != 0) { 126 if ((non_object_regs & (1 << r)) != 0) {
127 __ PushInt64AsTwoSmis(reg); 127 __ PushRegisterAsTwoSmis(reg);
128 } 128 }
129 } 129 }
130 130
131 #ifdef DEBUG 131 #ifdef DEBUG
132 __ RecordComment("// Calling from debug break to runtime - come in - over"); 132 __ RecordComment("// Calling from debug break to runtime - come in - over");
133 #endif 133 #endif
134 __ Set(rax, 0); // No arguments (argc == 0). 134 __ Set(rax, 0); // No arguments (argc == 0).
135 __ Move(rbx, ExternalReference::debug_break(masm->isolate())); 135 __ Move(rbx, ExternalReference::debug_break(masm->isolate()));
136 136
137 CEntryStub ceb(1); 137 CEntryStub ceb(1);
138 __ CallStub(&ceb); 138 __ CallStub(&ceb);
139 139
140 // Restore the register values from the expression stack. 140 // Restore the register values from the expression stack.
141 for (int i = kNumJSCallerSaved - 1; i >= 0; i--) { 141 for (int i = kNumJSCallerSaved - 1; i >= 0; i--) {
142 int r = JSCallerSavedCode(i); 142 int r = JSCallerSavedCode(i);
143 Register reg = { r }; 143 Register reg = { r };
144 if (FLAG_debug_code) { 144 if (FLAG_debug_code) {
145 __ Set(reg, kDebugZapValue); 145 __ Set(reg, kDebugZapValue);
146 } 146 }
147 if ((object_regs & (1 << r)) != 0) { 147 if ((object_regs & (1 << r)) != 0) {
148 __ Pop(reg); 148 __ Pop(reg);
149 } 149 }
150 // Reconstruct the 64-bit value from two smis. 150 // Reconstruct the 64-bit value from two smis.
151 if ((non_object_regs & (1 << r)) != 0) { 151 if ((non_object_regs & (1 << r)) != 0) {
152 __ PopInt64AsTwoSmis(reg); 152 __ PopRegisterAsTwoSmis(reg);
153 } 153 }
154 } 154 }
155 155
156 // Read current padding counter and skip corresponding number of words. 156 // Read current padding counter and skip corresponding number of words.
157 __ Pop(kScratchRegister); 157 __ Pop(kScratchRegister);
158 __ SmiToInteger32(kScratchRegister, kScratchRegister); 158 __ SmiToInteger32(kScratchRegister, kScratchRegister);
159 __ leap(rsp, Operand(rsp, kScratchRegister, times_pointer_size, 0)); 159 __ leap(rsp, Operand(rsp, kScratchRegister, times_pointer_size, 0));
160 160
161 // Get rid of the internal frame. 161 // Get rid of the internal frame.
162 } 162 }
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 346
347 const bool Debug::kFrameDropperSupported = true; 347 const bool Debug::kFrameDropperSupported = true;
348 348
349 #undef __ 349 #undef __
350 350
351 #endif // ENABLE_DEBUGGER_SUPPORT 351 #endif // ENABLE_DEBUGGER_SUPPORT
352 352
353 } } // namespace v8::internal 353 } } // namespace v8::internal
354 354
355 #endif // V8_TARGET_ARCH_X64 355 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698