ninja/win: Set /O2 compiler flag by default if no 'Optimization' specified

ninja/win: Set /O2 compiler flag by default if no 'Optimization' specified

Follows behavior when using MSVS generators. If target ends up with no
'Optimization' option specified, MSVS generator will not add <Optimization>
element in the <ClCompile> parent. Visual Studio will still set /O2 compile
flag though.

Tested only in VS2012 Express.

BUG=https://code.google.com/p/gyp/issues/detail?id=361
R=scottmg@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=1697

[Rafał Chłodnicki, 2013-08-19 21:00:20]

This is an attempt to fix linked bug. Unfortunately it did not get very much
testing. I only tested compiling our build (Opera) in Release mode (which fails
at linking without this fix).

Also, I didn't run the tests actually because I only have VS Express and it
seems like devenv.com is required to run tests which Express version doesn't
have.

[scottmg, 2013-08-19 21:03:26]

On 2013/08/19 21:00:20, Rafał Chłodnicki wrote:
> This is an attempt to fix linked bug. Unfortunately it did not get very much
> testing. I only tested compiling our build (Opera) in Release mode (which
fails
> at linking without this fix).
> 
> Also, I didn't run the tests actually because I only have VS Express and it
> seems like http://devenv.com is required to run tests which Express version
doesn't
> have.

You should be able to run the tests via trybot with "gcl try".

[Rafał Chłodnicki, 2013-08-19 21:13:20]

On 2013/08/19 21:03:26, scottmg wrote:
> You should be able to run the tests via trybot with "gcl try".

Might be doing something wrong or it will just not let me:

gcl try gyp-ninja -u rchlodnicki@opera.com --email rchlodnicki@opera.com
Results will be emailed to: rchlodnicki@opera.com
Authentication realm: <svn://svn.chromium.org:3690>
d3034d56-2935-4dfe-8f09-8ccb5d06043e
Password for 'rchlodnicki':

Authentication realm: <svn://svn.chromium.org:3690>
d3034d56-2935-4dfe-8f09-8ccb5d06043e
Username: rchlodnicki@opera.com
Password for 'rchlodnicki@opera.com':

Authentication realm: <svn://svn.chromium.org:3690>
d3034d56-2935-4dfe-8f09-8ccb5d06043e
Username:
Password for '':

svn: E170001: Unable to connect to a repository at URL
'svn://svn.chromium.org/chrome-try/try-nacl'
svn: E170001: SASL authentication error: SASL(-1): generic failure:
All-whitespace username.: No such file or directory
Command /usr/bin/svn import -q
/cygdrive/c/Users/RCHLOD~1/AppData/Local/Temp/tmpoR6AuW
svn://svn.chromium.org/chrome-try/try-nacl --file
/cygdrive/c/Users/RCHLOD~1/AppData/Local/Temp/tmp77A99e --no-ignore returned
non-zero exit status 1
Sorry, Tryserver is not available.


Message seems to suggest that server is not available but in fact I don't think
it accepts my credentials.

[scottmg, 2013-08-19 21:18:53]

On 2013/08/19 21:13:20, Rafał Chłodnicki wrote:
> On 2013/08/19 21:03:26, scottmg wrote:
> > You should be able to run the tests via trybot with "gcl try".
> 
> Might be doing something wrong or it will just not let me:
> 
> gcl try gyp-ninja -u mailto:rchlodnicki@opera.com --email
mailto:rchlodnicki@opera.com
> Results will be emailed to: mailto:rchlodnicki@opera.com
> Authentication realm: <svn://svn.chromium.org:3690>
> d3034d56-2935-4dfe-8f09-8ccb5d06043e
> Password for 'rchlodnicki':
> 
> Authentication realm: <svn://svn.chromium.org:3690>
> d3034d56-2935-4dfe-8f09-8ccb5d06043e
> Username: mailto:rchlodnicki@opera.com
> Password for 'rchlodnicki@opera.com':
> 
> Authentication realm: <svn://svn.chromium.org:3690>
> d3034d56-2935-4dfe-8f09-8ccb5d06043e
> Username:
> Password for '':
> 
> svn: E170001: Unable to connect to a repository at URL
> 'svn://svn.chromium.org/chrome-try/try-nacl'
> svn: E170001: SASL authentication error: SASL(-1): generic failure:
> All-whitespace username.: No such file or directory
> Command /usr/bin/svn import -q
> /cygdrive/c/Users/RCHLOD~1/AppData/Local/Temp/tmpoR6AuW
> svn://svn.chromium.org/chrome-try/try-nacl --file
> /cygdrive/c/Users/RCHLOD~1/AppData/Local/Temp/tmp77A99e --no-ignore returned
> non-zero exit status 1
> Sorry, Tryserver is not available.
> 
> 
> Message seems to suggest that server is not available but in fact I don't
think
> it accepts my credentials.

OK, I'm not sure. I started them anyway.

[scottmg, 2013-08-19 22:18:35]

lgtm, I will land it.

[scottmg, 2013-08-19 22:22:07]

Committed patchset #2 manually as r1697.