test/win/gyptest-cl-optimizations.py - Issue 23253003: ninja/win: Set /O2 compiler flag by default if no 'Optimization' specified

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/win/gyptest-cl-optimizations.py

Issue 23253003: ninja/win: Set /O2 compiler flag by default if no 'Optimization' specified (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/win/gyptest-cl-optimizations.py

===================================================================

--- test/win/gyptest-cl-optimizations.py (revision 1696)

+++ test/win/gyptest-cl-optimizations.py (working copy)

@@ -37,8 +37,9 @@

ninja_file = test.built_file_path('obj/test_opt_unset.ninja', chdir=CHDIR)

test.must_not_contain(ninja_file, '/Od')

test.must_not_contain(ninja_file, '/O1')

- test.must_not_contain(ninja_file, '/O2')

test.must_not_contain(ninja_file, '/Ox')

+ # Set by default if none specified.

+ test.must_contain(ninja_file, '/O2')

ninja_file = test.built_file_path('obj/test_opt_fpo.ninja', chdir=CHDIR)

test.must_contain(ninja_file, '/Oy')

« no previous file with comments | « pylib/gyp/msvs_emulation.py ('k') | no next file » | no next file with comments »