Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2325193002: MD Settings/About: Implement update progress percentage (Closed)

Created:
4 years, 3 months ago by Dan Beam
Modified:
4 years, 3 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings/About: Implement update progress percentage R=hcarmona@chromium.org BUG=626508 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8b9bbf145d2b0051285fdde3a81c5d6fda014baf Cr-Commit-Position: refs/heads/master@{#417801}

Patch Set 1 : fix tests #

Total comments: 2

Patch Set 2 : also add % to cross-channel cros message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M chrome/app/settings_chromium_strings.grdp View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/settings_google_chrome_strings.grdp View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/settings_strings.grdp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/about_page/about_page.js View 1 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/test/data/webui/settings/about_page_tests.js View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 26 (19 generated)
Dan Beam
4 years, 3 months ago (2016-09-09 19:05:58 UTC) #10
hcarmona
https://codereview.chromium.org/2325193002/diff/80001/chrome/browser/resources/settings/about_page/about_page.js File chrome/browser/resources/settings/about_page/about_page.js (right): https://codereview.chromium.org/2325193002/diff/80001/chrome/browser/resources/settings/about_page/about_page.js#newcode166 chrome/browser/resources/settings/about_page/about_page.js:166: this.i18n(settings.browserChannelToI18nId(this.targetChannel_))); Does changing the channel also need a progress ...
4 years, 3 months ago (2016-09-09 21:51:52 UTC) #15
Dan Beam
https://codereview.chromium.org/2325193002/diff/80001/chrome/browser/resources/settings/about_page/about_page.js File chrome/browser/resources/settings/about_page/about_page.js (right): https://codereview.chromium.org/2325193002/diff/80001/chrome/browser/resources/settings/about_page/about_page.js#newcode166 chrome/browser/resources/settings/about_page/about_page.js:166: this.i18n(settings.browserChannelToI18nId(this.targetChannel_))); On 2016/09/09 21:51:52, Hector Carmona wrote: > Does ...
4 years, 3 months ago (2016-09-10 00:56:03 UTC) #17
hcarmona
lgtm
4 years, 3 months ago (2016-09-10 01:00:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325193002/120001
4 years, 3 months ago (2016-09-10 01:14:21 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:120001)
4 years, 3 months ago (2016-09-10 02:11:56 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 02:13:41 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8b9bbf145d2b0051285fdde3a81c5d6fda014baf
Cr-Commit-Position: refs/heads/master@{#417801}

Powered by Google App Engine
This is Rietveld 408576698