Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4743)

Unified Diff: chrome/browser/resources/settings/about_page/about_page.js

Issue 2325193002: MD Settings/About: Implement update progress percentage (Closed)
Patch Set: also add % to cross-channel cros message Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/test/data/webui/settings/about_page_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/about_page/about_page.js
diff --git a/chrome/browser/resources/settings/about_page/about_page.js b/chrome/browser/resources/settings/about_page/about_page.js
index df86d49102ab781cf575745575e0ef4d4cc2565d..dc61dbb1f5cc056455c123503d309d6fad3174e5 100644
--- a/chrome/browser/resources/settings/about_page/about_page.js
+++ b/chrome/browser/resources/settings/about_page/about_page.js
@@ -160,13 +160,17 @@ Polymer({
case UpdateStatus.UPDATED:
return this.i18n('aboutUpgradeUpToDate');
case UpdateStatus.UPDATING:
+ assert(typeof this.currentUpdateStatusEvent_.progress == 'number');
+ var progressPercent = this.currentUpdateStatusEvent_.progress + '%';
+
<if expr="chromeos">
if (this.currentChannel_ != this.targetChannel_) {
return this.i18n('aboutUpgradeUpdatingChannelSwitch',
- this.i18n(settings.browserChannelToI18nId(this.targetChannel_)));
+ this.i18n(settings.browserChannelToI18nId(this.targetChannel_)),
+ progressPercent);
}
</if>
- return this.i18n('aboutUpgradeUpdating');
+ return this.i18n('aboutUpgradeUpdating', progressPercent);
default:
var message = this.currentUpdateStatusEvent_.message;
return message ?
« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/test/data/webui/settings/about_page_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698