Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2325093002: Replace ASSERT*() with DCHECK*() in core/xmlhttprequest/ (Closed)

Created:
4 years, 3 months ago by hiroshige
Modified:
4 years, 3 months ago
CC:
blink-reviews, chromium-reviews, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT*() with DCHECK*() in core/xmlhttprequest/ BUG=645395, 596760 Committed: https://crrev.com/1fc1b2f026bdd7869b9db224b87bafddbea7fb27 Cr-Commit-Position: refs/heads/master@{#417558}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -33 lines) Patch
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 27 chunks +31 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
hiroshige
PTAL.
4 years, 3 months ago (2016-09-09 09:31:54 UTC) #3
tyoshino (SeeGerritForStatus)
lgtm
4 years, 3 months ago (2016-09-09 11:16:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325093002/20001
4 years, 3 months ago (2016-09-09 11:28:23 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 11:31:15 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 11:33:58 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1fc1b2f026bdd7869b9db224b87bafddbea7fb27
Cr-Commit-Position: refs/heads/master@{#417558}

Powered by Google App Engine
This is Rietveld 408576698