third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.cpp - Issue 2325093002: Replace ASSERT*() with DCHECK*() in core/xmlhttprequest/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.cpp

Issue 2325093002: Replace ASSERT*() with DCHECK*() in core/xmlhttprequest/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.cpp

diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.cpp b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.cpp

index 42456f2abc09259bbd8a06a79a53d70d51f5bfeb..158963ae631d7c6e077560ce5b67bf3f1c2d2028 100644

--- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.cpp

+++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.cpp

@@ -60,7 +60,7 @@ void XMLHttpRequestUpload::dispatchProgressEvent(unsigned long long bytesSent, u

void XMLHttpRequestUpload::dispatchEventAndLoadEnd(const AtomicString& type, bool lengthComputable, unsigned long long bytesSent, unsigned long long total)

{

- ASSERT(type == EventTypeNames::load || type == EventTypeNames::abort || type == EventTypeNames::error || type == EventTypeNames::timeout);

+ DCHECK(type == EventTypeNames::load || type == EventTypeNames::abort || type == EventTypeNames::error || type == EventTypeNames::timeout);

InspectorInstrumentation::AsyncTask asyncTask(getExecutionContext(), m_xmlHttpRequest, m_xmlHttpRequest->isAsync());

dispatchEvent(ProgressEvent::create(type, lengthComputable, bytesSent, total));

dispatchEvent(ProgressEvent::create(EventTypeNames::loadend, lengthComputable, bytesSent, total));

« no previous file with comments | « third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp ('k') | no next file » | no next file with comments »