[DevTools] Migrate RequestHeadersView to TreeOutlineInShadow.

[DevTools] Migrate RequestHeadersView to TreeOutlineInShadow.

This is a step towards turning all tree outlines into independent web components,
removing global styles related to it and allowing more components to encapsulate their inner details.

BUG=none

Committed: https://crrev.com/9dcd25b8a2dce4ff27284123cc4d4bf0b6e90661
Cr-Commit-Position: refs/heads/master@{#417507}

[dgozman, 2016-09-09 00:58:22]

dgozman@chromium.org changed reviewers:
+ allada@chromium.org

[dgozman, 2016-09-09 00:58:23]

Could you please take a look?

[allada, 2016-09-09 01:40:40]

lgtm

https://codereview.chromium.org/2325003002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
(right):

https://codereview.chromium.org/2325003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js:51:
root.makeDense();
Can we instead move this into the constructor of TreeOutlineInShadow() so we
don't need to expose it?

https://codereview.chromium.org/2325003002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/requestHeadersView.css
(right):

https://codereview.chromium.org/2325003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/requestHeadersView.css:26:
padding: 0 0 0 4px;
Do we need to explicitly set padding to 0 for non-left paddings, if not use
padding-left: 4px; instead?

[dgozman, 2016-09-09 02:27:50]

https://codereview.chromium.org/2325003002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
(right):

https://codereview.chromium.org/2325003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js:51:
root.makeDense();
On 2016/09/09 01:40:40, Blaise wrote:
> Can we instead move this into the constructor of TreeOutlineInShadow() so we
> don't need to expose it?

As discussed offline, our current style is a bunch of makeXXX methods to make it
manageable.

https://codereview.chromium.org/2325003002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/requestHeadersView.css
(right):

https://codereview.chromium.org/2325003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/requestHeadersView.css:26:
padding: 0 0 0 4px;
On 2016/09/09 01:40:40, Blaise wrote:
> Do we need to explicitly set padding to 0 for non-left paddings, if not use
> padding-left: 4px; instead?

I'll follow up with removing default padding from treeoutline.css.

[dgozman, 2016-09-09 02:27:54]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-09-09 02:28:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 05:06:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-09 05:07:56]

Description was changed from

==========
[DevTools] Migrate RequestHeadersView to TreeOutlineInShadow.

This is a step towards turning all tree outlines into independent web
components,
removing global styles related to it and allowing more components to encapsulate
their inner details.

BUG=none
==========

to

==========
[DevTools] Migrate RequestHeadersView to TreeOutlineInShadow.

This is a step towards turning all tree outlines into independent web
components,
removing global styles related to it and allowing more components to encapsulate
their inner details.

BUG=none

Committed: https://crrev.com/9dcd25b8a2dce4ff27284123cc4d4bf0b6e90661
Cr-Commit-Position: refs/heads/master@{#417507}
==========

[commit-bot: I haz the power, 2016-09-09 05:07:57]

Patchset 1 (id:??) landed as
https://crrev.com/9dcd25b8a2dce4ff27284123cc4d4bf0b6e90661
Cr-Commit-Position: refs/heads/master@{#417507}