third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js - Issue 2325003002: [DevTools] Migrate RequestHeadersView to TreeOutlineInShadow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js

Issue 2325003002: [DevTools] Migrate RequestHeadersView to TreeOutlineInShadow. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/BUILD.gn ('k') | third_party/WebKit/Source/devtools/front_end/network/module.json » ('j') | third_party/WebKit/Source/devtools/front_end/network/requestHeadersView.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js

index dcd77aec07b58c59fb5d981eba080c89e4811a6d..67a88895a1ae9749e6da84464b4c10837e8e0e89 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js

@@ -44,8 +44,11 @@ WebInspector.RequestHeadersView = function(request)

this._showRequestHeadersText = false;

this._showResponseHeadersText = false;

- var root = new TreeOutline(true);

- root.element.classList.add("outline-disclosure");

+ var root = new TreeOutlineInShadow();

+ root.registerRequiredCSS("network/requestHeadersTree.css");

+ root.element.classList.add("request-headers-tree");

+ root.setFocusable(false);

+ root.makeDense();

allada 2016/09/09 01:40:40 Can we instead move this into the constructor of T

dgozman 2016/09/09 02:27:50 As discussed offline, our current style is a bunch

root.expandTreeElementsWhenArrowing = true;

this.element.appendChild(root.element);