Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2324993002: Quick View: avoid to lose focus when metadata button is clicked. (Closed)

Created:
4 years, 3 months ago by oka
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Quick View: avoid to lose focus when metadata button is clicked. BUG=641587 TEST=manually tested. 1. Click -> Space closes Quick View. 2. Move the focus to the button with tab -> Space -> Space closes Quick View. Review-Url: https://codereview.chromium.org/2305563002 Cr-Commit-Position: refs/heads/master@{#416152} (cherry picked from commit 8f31d60b1c0895387266a24d63c3d44f5df97ea5) Committed: https://chromium.googlesource.com/chromium/src/+/9d28aae1c305384437514c55dd2896d248891d12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/elements/files_quick_view.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_quick_view.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
oka
4 years, 3 months ago (2016-09-09 00:56:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9d28aae1c305384437514c55dd2896d248891d12.

Powered by Google App Engine
This is Rietveld 408576698