Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2305563002: Quick View: avoid to lose focus when metadata button is clicked. (Closed)

Created:
4 years, 3 months ago by oka
Modified:
4 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Quick View: avoid to lose focus when metadata button is clicked. BUG=641587 TEST=manually tested. 1. Click -> Space closes Quick View. 2. Move the focus to the button with tab -> Space -> Space closes Quick View. Committed: https://crrev.com/8f31d60b1c0895387266a24d63c3d44f5df97ea5 Cr-Commit-Position: refs/heads/master@{#416152}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 4

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/elements/files_quick_view.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_quick_view.js View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
oka
PTAL.
4 years, 3 months ago (2016-09-01 08:38:22 UTC) #4
fukino
https://codereview.chromium.org/2305563002/diff/20001/ui/file_manager/file_manager/foreground/elements/files_quick_view.js File ui/file_manager/file_manager/foreground/elements/files_quick_view.js (right): https://codereview.chromium.org/2305563002/diff/20001/ui/file_manager/file_manager/foreground/elements/files_quick_view.js#newcode151 ui/file_manager/file_manager/foreground/elements/files_quick_view.js:151: this.$['metadata-button'].addEventListener('click', function(e) { I think adding "on-tap=" attribute for ...
4 years, 3 months ago (2016-09-01 09:00:04 UTC) #5
oka
Address comments.
4 years, 3 months ago (2016-09-01 09:28:44 UTC) #7
oka
PTAL. https://codereview.chromium.org/2305563002/diff/20001/ui/file_manager/file_manager/foreground/elements/files_quick_view.js File ui/file_manager/file_manager/foreground/elements/files_quick_view.js (right): https://codereview.chromium.org/2305563002/diff/20001/ui/file_manager/file_manager/foreground/elements/files_quick_view.js#newcode151 ui/file_manager/file_manager/foreground/elements/files_quick_view.js:151: this.$['metadata-button'].addEventListener('click', function(e) { On 2016/09/01 09:00:04, fukino wrote: ...
4 years, 3 months ago (2016-09-01 09:35:47 UTC) #9
fukino
lgtm
4 years, 3 months ago (2016-09-01 10:37:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305563002/40001
4 years, 3 months ago (2016-09-02 00:31:52 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-02 01:21:10 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 01:23:13 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8f31d60b1c0895387266a24d63c3d44f5df97ea5
Cr-Commit-Position: refs/heads/master@{#416152}

Powered by Google App Engine
This is Rietveld 408576698