Quick View: avoid to lose focus when metadata button is clicked.

Quick View: avoid to lose focus when metadata button is clicked.

BUG=641587
TEST=manually tested.
1. Click -> Space closes Quick View.
2. Move the focus to the button with tab -> Space -> Space closes Quick View.

Committed: https://crrev.com/8f31d60b1c0895387266a24d63c3d44f5df97ea5
Cr-Commit-Position: refs/heads/master@{#416152}

[oka, 2016-09-01 06:47:36]

Description was changed from

==========
Quick View: avoid to lose focus when metadata button is clicked.

BUG=641587
==========

to

==========
Quick View: avoid to lose focus when metadata button is clicked.

BUG=641587
TEST=manually tested.
==========

[oka, 2016-09-01 06:47:36]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2016-09-01 06:48:44]

Description was changed from

==========
Quick View: avoid to lose focus when metadata button is clicked.

BUG=641587
TEST=manually tested.
==========

to

==========
Quick View: avoid to lose focus when metadata button is clicked.

BUG=641587
TEST=manually tested.
1. Click -> Space closes Quick View
2. Move the focus with tab to metadata button -> Space -> Space toggles metadata
panel and doesn't close Quick View.
==========

[oka, 2016-09-01 08:38:22]

PTAL.

[fukino, 2016-09-01 09:00:04]

https://codereview.chromium.org/2305563002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.js
(right):

https://codereview.chromium.org/2305563002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.js:151:
this.$['metadata-button'].addEventListener('click', function(e) {
I think adding "on-tap=" attribute for the metadata-button would be simpler.

https://codereview.chromium.org/2305563002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.js:154: if
(e.screenX > 0 || e.screenY > 0) { // clicked by mouse or tap.
Can't we always focus the content panel on clicks? Is there a problem?

[oka, 2016-09-01 09:14:52]

Description was changed from

==========
Quick View: avoid to lose focus when metadata button is clicked.

BUG=641587
TEST=manually tested.
1. Click -> Space closes Quick View
2. Move the focus with tab to metadata button -> Space -> Space toggles metadata
panel and doesn't close Quick View.
==========

to

==========
Quick View: avoid to lose focus when metadata button is clicked.

BUG=641587
TEST=manually tested.
1. Click -> Space closes Quick View.
==========

[oka, 2016-09-01 09:28:44]

Address comments.

[oka, 2016-09-01 09:30:25]

Description was changed from

==========
Quick View: avoid to lose focus when metadata button is clicked.

BUG=641587
TEST=manually tested.
1. Click -> Space closes Quick View.
==========

to

==========
Quick View: avoid to lose focus when metadata button is clicked.

BUG=641587
TEST=manually tested.
1. Click -> Space closes Quick View.
2. Move the focus to the button with tab -> Space -> Space closes Quick View.
==========

[oka, 2016-09-01 09:35:47]

PTAL.

https://codereview.chromium.org/2305563002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.js
(right):

https://codereview.chromium.org/2305563002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.js:151:
this.$['metadata-button'].addEventListener('click', function(e) {
On 2016/09/01 09:00:04, fukino wrote:
> I think adding "on-tap=" attribute for the metadata-button would be simpler.

Done.

https://codereview.chromium.org/2305563002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.js:154: if
(e.screenX > 0 || e.screenY > 0) { // clicked by mouse or tap.
On 2016/09/01 09:00:04, fukino wrote:
> Can't we always focus the content panel on clicks? Is there a problem?

Done.
I thought focus should be stick to the button if button is pressed by keyboard,
but moving focus to the main panel is consistent behaviour with the Files App's
button to toggle list view and thumbnail view.

[fukino, 2016-09-01 10:37:45]

lgtm

[oka, 2016-09-02 00:31:07]

The CQ bit was checked by oka@chromium.org

[commit-bot: I haz the power, 2016-09-02 00:31:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 01:21:09]

Description was changed from

==========
Quick View: avoid to lose focus when metadata button is clicked.

BUG=641587
TEST=manually tested.
1. Click -> Space closes Quick View.
2. Move the focus to the button with tab -> Space -> Space closes Quick View.
==========

to

==========
Quick View: avoid to lose focus when metadata button is clicked.

BUG=641587
TEST=manually tested.
1. Click -> Space closes Quick View.
2. Move the focus to the button with tab -> Space -> Space closes Quick View.
==========

[commit-bot: I haz the power, 2016-09-02 01:21:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-02 01:23:12]

Description was changed from

==========
Quick View: avoid to lose focus when metadata button is clicked.

BUG=641587
TEST=manually tested.
1. Click -> Space closes Quick View.
2. Move the focus to the button with tab -> Space -> Space closes Quick View.
==========

to

==========
Quick View: avoid to lose focus when metadata button is clicked.

BUG=641587
TEST=manually tested.
1. Click -> Space closes Quick View.
2. Move the focus to the button with tab -> Space -> Space closes Quick View.

Committed: https://crrev.com/8f31d60b1c0895387266a24d63c3d44f5df97ea5
Cr-Commit-Position: refs/heads/master@{#416152}
==========

[commit-bot: I haz the power, 2016-09-02 01:23:13]

Patchset 3 (id:??) landed as
https://crrev.com/8f31d60b1c0895387266a24d63c3d44f5df97ea5
Cr-Commit-Position: refs/heads/master@{#416152}