Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: ios/chrome/browser/suggestions/ios_image_decoder_impl.h

Issue 2324793002: Support WebP images in the IOSImageDecoderImpl (Closed)
Patch Set: noyau@ comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/suggestions/ios_image_decoder_impl.h
diff --git a/ios/chrome/browser/suggestions/ios_image_decoder_impl.h b/ios/chrome/browser/suggestions/ios_image_decoder_impl.h
index 32b31ed7ad1e74fc2f01de4a94459616df48e42e..d1388507d5525e8e12927efa9a6616ed22883de1 100644
--- a/ios/chrome/browser/suggestions/ios_image_decoder_impl.h
+++ b/ios/chrome/browser/suggestions/ios_image_decoder_impl.h
@@ -5,23 +5,19 @@
#ifndef IOS_CHROME_BROWSER_SUGGESTIONS_IOS_IMAGE_DECODER_IMPL_H_
#define IOS_CHROME_BROWSER_SUGGESTIONS_IOS_IMAGE_DECODER_IMPL_H_
-#include "base/macros.h"
+#include "base/memory/ref_counted.h"
#include "components/image_fetcher/image_decoder.h"
-namespace suggestions {
-
-class IOSImageDecoderImpl : public image_fetcher::ImageDecoder {
- public:
- IOSImageDecoderImpl();
- ~IOSImageDecoderImpl() override;
+namespace base {
+class TaskRunner;
+}
- void DecodeImage(
- const std::string& image_data,
- const image_fetcher::ImageDecodedCallback& callback) override;
+namespace suggestions {
- private:
- DISALLOW_COPY_AND_ASSIGN(IOSImageDecoderImpl);
-};
+// The IOSImageDecoderImpl class is in .mm file, so that it could be used in .cc
sdefresne 2016/10/05 09:15:28 style: Declaration comments describe use of the fu
vitaliii 2016/10/06 06:35:08 Done.
+// files through the function below.
+std::unique_ptr<image_fetcher::ImageDecoder> createIOSImageDecoder(
sdefresne 2016/10/05 09:15:28 style: Regular functions have mixed case; "cheap"
vitaliii 2016/10/06 06:35:08 Done.
+ scoped_refptr<base::TaskRunner> task_runner);
} // namespace suggestions

Powered by Google App Engine
This is Rietveld 408576698