Support WebP images in the IOSImageDecoderImpl

ios/chrome/browser/suggestions/ios_image_decoder_impl.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_CHROME_BROWSER_SUGGESTIONS_IOS_IMAGE_DECODER_IMPL_H_
 #define IOS_CHROME_BROWSER_SUGGESTIONS_IOS_IMAGE_DECODER_IMPL_H_
 
-#include "base/macros.h"
+#include "base/memory/ref_counted.h"
 #include "components/image_fetcher/image_decoder.h"
 
+namespace base {
+class TaskRunner;
+}
+
 namespace suggestions {
 
-class IOSImageDecoderImpl : public image_fetcher::ImageDecoder {
- public:
-  IOSImageDecoderImpl();
-  ~IOSImageDecoderImpl() override;
-
-  void DecodeImage(
-      const std::string& image_data,
-      const image_fetcher::ImageDecodedCallback& callback) override;
-
- private:
-  DISALLOW_COPY_AND_ASSIGN(IOSImageDecoderImpl);
-};
+// The IOSImageDecoderImpl class is in .mm file, so that it could be used in .cc

[sdefresne, 2016/10/05 09:15:28]

style: Declaration comments describe use of the function (when it is
non-obvious); comments at the definition of a function describe operation
(https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.shtml?cl=head#...).

I would recommend to instead say something like this (the fact that the class is
private is an implementation detail):

// Factory for iOS specific implementation of image_fetcher::ImageDecoder.

[vitaliii, 2016/10/06 06:35:08]

Done.

+// files through the function below.
+std::unique_ptr<image_fetcher::ImageDecoder> createIOSImageDecoder(

[sdefresne, 2016/10/05 09:15:28]

style: Regular functions have mixed case; "cheap" functions may use lower case
with underscores
(https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.shtml?cl=head#...).

Rename this to CreateIOSImageDecoder instead.

[vitaliii, 2016/10/06 06:35:08]

Done.

+    scoped_refptr<base::TaskRunner> task_runner);
 
 }  // namespace suggestions
 
 #endif  // IOS_CHROME_BROWSER_SUGGESTIONS_IOS_IMAGE_DECODER_IMPL_H_